Skip to content

Fix proxies support #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2021
Merged

Fix proxies support #111

merged 1 commit into from
Dec 4, 2021

Conversation

dimon222
Copy link
Collaborator

Unfortunately proxy support in #109 to fix #108 was done only on base class but was forgotten on:

  1. Inherited classes
  2. Healthcheck polling calls that should identify active node.

This should fix both.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1488489730

  • 15 of 15 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.524%
Totals Coverage Status
Change from base Build 1465366147: 0.0%
Covered Lines: 658
Relevant Lines: 735
💛 - Coveralls

@dimon222 dimon222 merged commit 4207012 into gateway-experiments:master Dec 4, 2021
@dimon222 dimon222 deleted the bugfix/fix_proxies branch December 4, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lresende lresende Awaiting requested review from lresende

@kevin-bates kevin-bates Awaiting requested review from kevin-bates

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SOCKS proxy support
2 participants
@dimon222 @coveralls