chore: post ferries release alignment #607
Conversation
feat: ferries, cicka and metrics
…develop-alignment
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mateuszaaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on post-release alignment, incorporating various updates and enhancements. It includes critical tooling updates for development environments, a submodule synchronization, the introduction of a configurable Prometheus metrics port for better observability, and improvements to error logging for clearer diagnostics.
Highlights
- Tooling & Infrastructure Updates: Updated Foundry Docker image versions in
contracts/compose.anvil-stubs.ymlforeth-stub,arbitrum-stub, andbase-stubservices to a newergaspxyzbuild, ensuring compatibility with the latest development environment. - Submodule Synchronization: Synchronized the
gasp-e2esubmodule to its latest commit (a997e99918f28da9b15ba94dd96f16cde7082052), pulling in recent end-to-end test changes and updates. - New Feature: Configurable Metrics Port: Implemented a new command-line argument and environment variable (
--prometheus-port/PROMETHEUS_PORT) in the sequencer. This allows operators to specify a custom port for the Prometheus metrics server, enhancing deployment flexibility. - Logging Improvements: Enhanced error messages across sequencer components (
sequencer/closer/src/batch_subscription.rsandsequencer/l1api/src/lib.rs) to include detailed error information for L1, L2, and Alloy-related errors, improving diagnostic capabilities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces several changes, including CI fixes, dependency updates (Foundry image and gasp-e2e submodule), improvements to error logging messages, and a new feature for a configurable Prometheus metrics port. My review focuses on the newly added background tasks for metrics, suggesting an enhancement for better observability in case of unexpected termination.
| common::report_account_balance(p).await; | ||
| }); | ||
| let _metrics = tokio::spawn(async move { | ||
| common::serve_metrics(port).await; |
There was a problem hiding this comment.
The common::serve_metrics function, which starts the Prometheus metrics server, is expected to run indefinitely. If it exits (e.g., warp::serve(...).run(...).await returns), it might indicate an issue like the server failing to bind or another unexpected shutdown. Adding a log message after this call will help in diagnosing such situations, as the task would otherwise terminate silently from the perspective of this main function (though Tokio's panic hook might log panics).
This improves the observability of a critical component for monitoring.
common::serve_metrics(port).await;
tracing::warn!("Prometheus metrics server task for port {} has unexpectedly exited.", port);
Run report for fd1d46a4
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SyncWorkspace |
223.6ms | Passed | |
| ⬛️ | SetupToolchain(system) |
0.2ms | Skipped | |
| 🟩 | SyncProject(system, gasp-avs) |
1.5ms | Passed | |
| 🟩 | SyncProject(system, sequencer) |
2ms | Passed | |
| 🟩 | SyncProject(system, contracts) |
1.3ms | Passed | |
| 🟦 | RunTask(contracts:buildkit-build-and-push-image-digests) |
503.7ms | Cached | |
| 🟦 | RunTask(sequencer:buildkit-build-and-push-image-digests) |
504.7ms | Cached | |
| 🟩 | SyncProject(system, updater) |
1.5ms | Passed | |
| 🟩 | SyncProject(system, avs-aggregator) |
6.8ms | Passed | |
| 🟩 | SyncProject(system, gasp-node) |
9.8ms | Passed | |
| 🟦 | RunTask(gasp-avs:buildkit-build-and-push-image-digests) |
388.3ms | Cached | |
| 🟦 | RunTask(avs-aggregator:buildkit-build-and-push-image-digests) |
426.9ms | Cached | |
| 🟦 | RunTask(gasp-node:buildkit-build-and-push-image-digests-standard-runtime) |
426.2ms | Cached | |
| 🟩 | SetupToolchain(node:22.14.0) |
5.3s | Passed | |
| 🟦 | RunTask(gasp-node:buildkit-build-and-push-image-digests-fast-runtime) |
780.2ms | Cached | |
| 🟦 | RunTask(updater:buildkit-build-and-push-image-digests) |
222.1ms | Cached | |
| 🟩 | RunTask(contracts:build-image-ci) |
6s | Passed | |
| 🟩 | SetupToolchain(node:18.20.7) |
8.3s | Passed | |
| 🟩 | SyncProject(node, stash) |
0.8ms | Passed | |
| 🟩 | RunTask(sequencer:build-image-ci) |
10.6s | Passed | |
| And 12 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | RunTask(gasp-avs:build-image-ci) |
6.8s | Passed | |
| 🟩 | SyncProject(node, ferry-deposit) |
0.5ms | Passed | |
| 🟩 | SyncProject(node, ferry-withdrawal) |
0.5ms | Passed | |
| 🟦 | RunTask(stash:buildkit-build-and-push-image-digests) |
305.1ms | Cached | |
| 🟦 | RunTask(ferry-deposit:buildkit-build-and-push-image-digests) |
200ms | Cached | |
| 🟦 | RunTask(ferry-withdrawal:buildkit-build-and-push-image-digests) |
202.3ms | Cached | |
| 🟩 | RunTask(avs-aggregator:build-image-ci) |
7.2s | Passed | |
| 🟩 | RunTask(updater:build-image-ci) |
7.2s | Passed | |
| 🟩 | RunTask(stash:build-image-ci) |
6s | Passed | |
| 🟩 | RunTask(ferry-deposit:build-image-ci) |
8s | Passed | |
| 🟩 | RunTask(gasp-node:build-image-ci) |
14.4s | Passed | |
| 🟩 | RunTask(ferry-withdrawal:build-image-ci) |
7.5s | Passed |
Environment
OS: Linux
Matrix:
prefix = build-docker-images
name = Build docker images
runner = ubuntu-24.04
buildkit-enable = true
buildkit-replicas = 5
command = moon :build-image-ci
Variables:
MOON_COLOR = 2
MOON_DEBUG_PROTO_INSTALL = false
MOON_CACHE = read-write
MOON_VERSION = 1.34.0
Touched files
contracts/compose.anvil-stubs.yml
sequencer/closer/src/batch_subscription.rs
sequencer/closer/src/cli.rs
sequencer/closer/src/main.rs
sequencer/l1api/src/lib.rs
mooncli to1.34.0version to be used within gha workflowsstash