-
Notifications
You must be signed in to change notification settings - Fork 6
Add bootstrap test in maintennaceMode #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: eth-rollup-develop
Are you sure you want to change the base?
Add bootstrap test in maintennaceMode #587
Conversation
|
|
||
| await setupBootstrapTokensBalance(bootstrapCurrency, sudo, [testUser1]); | ||
|
|
||
| await sudo.mint(bootstrapCurrency, testUser1, toBN("1", 20)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reuse the Asset.mint and add it to the next batchAsSudoFinalize. One day we will get rid of this sudo.mint stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| await claimRewardsBootstrap(testUser1).then((result) => { | ||
| const eventResponse = getEventResultFromMangataTx(result); | ||
| expect(eventResponse.state).toEqual(ExtrinsicResult.ExtrinsicFailed); | ||
| expect(eventResponse.data).toEqual(xykErrors.MathOverflow); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow. math overflow? :O
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is because the amount is 0 or -1
| const poolId = await getLiquidityAssetId(GASP_ASSET_ID, bootstrapCurrency); | ||
| expect(poolId).bnEqual(new BN(-1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be a side effect of no one being able to provide liq. Can you do another test that starts maintenance after a a provision being done? ie:
1,- CheckMaintenanceOff
2,- Start bootstrap
3,- Wait for Public phase and provision with one user
4,- start maintenance
5,- wait for boostrap finished.
6,- Check that bootstrap did not / did create the pool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scenario was created, but we have a bug here https://mangatafinance.atlassian.net/browse/GASP-2210
No description provided.