Skip to content

Conversation

@AlexChetverov
Copy link
Contributor

No description provided.


await setupBootstrapTokensBalance(bootstrapCurrency, sudo, [testUser1]);

await sudo.mint(bootstrapCurrency, testUser1, toBN("1", 20));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reuse the Asset.mint and add it to the next batchAsSudoFinalize. One day we will get rid of this sudo.mint stuff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

await claimRewardsBootstrap(testUser1).then((result) => {
const eventResponse = getEventResultFromMangataTx(result);
expect(eventResponse.state).toEqual(ExtrinsicResult.ExtrinsicFailed);
expect(eventResponse.data).toEqual(xykErrors.MathOverflow);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow. math overflow? :O

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is because the amount is 0 or -1

Comment on lines +344 to +345
const poolId = await getLiquidityAssetId(GASP_ASSET_ID, bootstrapCurrency);
expect(poolId).bnEqual(new BN(-1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be a side effect of no one being able to provide liq. Can you do another test that starts maintenance after a a provision being done? ie:
1,- CheckMaintenanceOff
2,- Start bootstrap
3,- Wait for Public phase and provision with one user
4,- start maintenance
5,- wait for boostrap finished.
6,- Check that bootstrap did not / did create the pool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scenario was created, but we have a bug here https://mangatafinance.atlassian.net/browse/GASP-2210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants