Skip to content

Conversation

@alanlomeli
Copy link
Member

(#2317)
Typing text hidden on mobile
Community sponsors optimized on mobile
Removal of news menu item
Minor tweaks
WIP: Still figuring out why the docs sidebar scrolls

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the text is hidden the first blue screen is rather empty:

image

Could you address that?

The header doesn't need the 1o0vh height and the buttons would need to be repositioned a bit.

top: 50%
left: 50%
transform: translate(-50%, -50%)
@include media-breakpoint-up(lg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use md here, we really just don't want it on mobile.

margin: 0 1rem
margin-bottom: 1rem

.card
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this fix, this works by accident, if is was a tweet and card that were stacked up on mobile this might not work.

You want to change the col-md-4 div to col-md-4 mt-4 mt-md-0. The second and third columns should push on mobile but not for md and higher.

@nojaf
Copy link
Contributor

nojaf commented Sep 10, 2022

@alanlomeli I found out we can solve the menu height problem by modifying the max height:

image

@alanlomeli alanlomeli marked this pull request as ready for review September 11, 2022 01:34
@alanlomeli
Copy link
Member Author

Thanks for the help :)

Typing text hidden on mobile
Community sponsors optimized on mobile
Removal of news menu item
Minor tweaks
Long scrollbar on docs sidebar menu fixed
Different fix for cards padding
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nojaf nojaf enabled auto-merge (squash) September 11, 2022 16:28
@nojaf nojaf merged commit 7fb34e5 into fsprojects:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants