Mobile optimizations #2496
Merged
Mobile optimizations #2496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
requested changes
Sep 10, 2022
Contributor
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
Now that the text is hidden the first blue screen is rather empty:
Could you address that?
The header doesn't need the 1o0vh height and the buttons would need to be repositioned a bit.
docs/.style/homepage.sass
Outdated
| top: 50% | ||
| left: 50% | ||
| transform: translate(-50%, -50%) | ||
| @include media-breakpoint-up(lg) |
Contributor
There was a problem hiding this comment.
Use md here, we really just don't want it on mobile.
docs/.style/homepage.sass
Outdated
| margin: 0 1rem | ||
| margin-bottom: 1rem | ||
|
|
||
| .card |
Contributor
There was a problem hiding this comment.
I don't like this fix, this works by accident, if is was a tweet and card that were stacked up on mobile this might not work.
You want to change the col-md-4 div to col-md-4 mt-4 mt-md-0. The second and third columns should push on mobile but not for md and higher.
Contributor
|
@alanlomeli I found out we can solve the menu height problem by modifying the max height:
|
alanlomeli
force-pushed
the
mobile-experience
branch
from
44429b1 to
181e326
Compare
Member
Author
|
Thanks for the help :) |
Typing text hidden on mobile Community sponsors optimized on mobile Removal of news menu item Minor tweaks
Long scrollbar on docs sidebar menu fixed Different fix for cards padding
nojaf
force-pushed
the
mobile-experience
branch
from
181e326 to
25c2e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#2317)
Typing text hidden on mobile
Community sponsors optimized on mobile
Removal of news menu item
Minor tweaks
WIP: Still figuring out why the docs sidebar scrolls