Allow importing utils.js in newer Node tools
#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readme.md says that the following works:
import {isContentScriptRegistered} from 'webext-dynamic-content-scripts/utils.js';
if (await isContentScriptRegistered('https://google.com/search')) {
console.log('Either way, the content scripts are registered');
}
However the import fails, because the "exports" section in package.json
doesn't export utils.js. So add an entry to export it, thereby making
the docs correct without needing to change them.
We don't add a wildcard entry to the "exports" section, because the
intention is to explicitly export certain files, and hide the rest as
internals.
It's also worth noting that the main file has side effects, so
utils.js is exported separately for the benefit of consumers who need
that but don't want the side effects.
Fixes fregante#67.
fregante
changed the title
utils.js in newer Node tools
Owner
|
Thank you @aspiers! Releasing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
readme.mdsays that the following works:However the import fails, because the
exportssection inpackage.jsondoesn't exportutils.js. So add an entry to export it, thereby making the docs correct without needing to change them.We don't add a wildcard entry to the
exportssection, because the intention is to explicitly export certain files, and hide the rest as internals.It's also worth noting that the main file has side effects, so
utils.jsis exported separately for the benefit of consumers who need that but don't want the side effects.Fixes #67.