Add optional support for activeTab injection
#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
CI fixed by #48 😮💨 |
fregante
commented
Jan 8, 2023
active-tab.ts
Outdated
| export function onActiveTab(callback: (tab: ActiveTab) => void) { | ||
| startActiveTabTracking(); | ||
| emitter.add(callback); | ||
| } |
There was a problem hiding this comment.
This file is ready to be exported to a separate module, likely webext-events
including-active-tab.ts
Outdated
| } | ||
| } | ||
|
|
||
| onActiveTab(injectToTab); |
There was a problem hiding this comment.
Manually tested:
- via context menu
- via browser action
Broken:
- registered top frame, unregistered inner frame: no op ❌
Edit: cross-origin iframes aren't covered by activeTab
5 tasks
Merged
Parcel keeps the files only in the dist/mv2 directly, generating invalid paths in the manifest.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isContentScriptRegistered#36Missing
activeTabsupport inisContentScriptRegisteredor similar,isContentScriptRegistered(url, tabId?) //=> activeTab still returns dynamicpossiblyActiveTabs.has(tabId)https-only injection logicDeal with
activeTabreload injections