Skip to content

Collect Capability Manager History directory #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

lhaagsma
Copy link
Contributor

This PR adds collection of files for the Capability Manager History plugin.

This complements the Dissect Target Plugin PR at: fox-it/dissect.target#1112

Aims to close #236

@lhaagsma
Copy link
Contributor Author

lhaagsma commented Apr 17, 2025

Tests likely do not work because the added code depends on newly introduced plugin in dissect.target that is not merged yet. How to proceed?
Update: for now made a version that does not depend on cam.history.

@lhaagsma lhaagsma force-pushed the capability-manager branch 2 times, most recently from 88a67fd to 6393161 Compare April 18, 2025 07:48
@lhaagsma lhaagsma force-pushed the capability-manager branch from 6393161 to bfd27b6 Compare April 18, 2025 12:37
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.52%. Comparing base (44b534e) to head (343abb5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
acquire/acquire.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   44.49%   44.52%   +0.03%     
==========================================
  Files          26       26              
  Lines        3513     3524      +11     
==========================================
+ Hits         1563     1569       +6     
- Misses       1950     1955       +5     
Flag Coverage Δ
unittests 44.52% <54.54%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lhaagsma lhaagsma force-pushed the capability-manager branch from e14786c to 2478f1c Compare May 7, 2025 06:21
@lhaagsma lhaagsma requested a review from twiggler May 7, 2025 06:22
@lhaagsma lhaagsma force-pushed the capability-manager branch from 2478f1c to 64e420e Compare May 7, 2025 06:23
Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the wrong button in the github review thingy

@lhaagsma lhaagsma requested a review from Miauwkeru May 7, 2025 09:36
@Miauwkeru Miauwkeru dismissed twiggler’s stale review May 7, 2025 10:57

changes where incorperated

@Miauwkeru Miauwkeru merged commit 480cb2f into fox-it:main May 7, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect Capability Manager History files
3 participants