feat(anvil): bypass eip-3607 when impersonating contracts #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
changed the title
|
It appears that on the latest release (0.1.0 (0dc266d 2022-08-05T00:08:59.907525Z)) the issue still persists. Attempting to call a contract from an impersonated account that is a contract results in |
|
can you please open a separate issue with a way to reproduce this? |
2 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As highlighted here #1943 (comment) when impersonating contracts, calls from the impersonated contract get rejected due to EIP-3607.
So it's required to remove the code first manually.
Solution
revm checks eip3607 by looking at the account's code hash, and rejects the call if it is not empty.
this temporarily sets the code hash of a contract to KECCAK_EMPTY so the revm check passes.
The downside of this is that this messes with revm internals and renders the contract's code unusable for the time the contract is impersonated, but the same happens when removing the code manually. So temporarily setting it to empty is less invasive