-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(anvil): set envelope for non deposit tx in debug tracers #12080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b115359
to
5df7eff
Compare
5df7eff
to
0eb06c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need tests? or is the effort-reward ratio so low that we can skip them?
it's quite complex, was able to repro and test with relay e2e but not sure how to translate in a simpler one... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, I only changed to 2718
this is pretty straight forward so we can skip the op test here
* fix(fmt): ensure commasep breaks with final trailing cmnt (#12031) * fix(fmt): refine logic over comments between uninformed commasep (#12055) * fix(anvil): set envelope for non deposit tx in debug tracers (#12080) * chore: bump v1.4.1 (#12083) chore: bumpt v1.4.1 * fix(fmt): don't normalize single-line non-doc block cmnts (#12078) * fix: don't normalize single-line non-doc block cmnts * fix: preserve consecutive whitespaces * fix: use byte length instead of char count --------- Co-authored-by: 0xrusowsky <[email protected]>
Motivation
Solution
PR Checklist