Skip to content

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Oct 13, 2025

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy marked this pull request as ready for review October 13, 2025 16:43
@grandizzy grandizzy enabled auto-merge (squash) October 13, 2025 16:43
Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need tests? or is the effort-reward ratio so low that we can skip them?

@grandizzy grandizzy disabled auto-merge October 13, 2025 16:53
@grandizzy
Copy link
Collaborator Author

do we need tests? or is the effort-reward ratio so low that we can skip them?

it's quite complex, was able to repro and test with relay e2e but not sure how to translate in a simpler one...

@grandizzy grandizzy enabled auto-merge (squash) October 13, 2025 17:00
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, I only changed to 2718

this is pretty straight forward so we can skip the op test here

@grandizzy grandizzy merged commit debdd44 into foundry-rs:master Oct 13, 2025
29 of 31 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 13, 2025
@grandizzy grandizzy deleted the anvil-tracer-fix branch October 14, 2025 02:28
grandizzy added a commit to grandizzy/foundry that referenced this pull request Oct 14, 2025
grandizzy added a commit that referenced this pull request Oct 14, 2025
* fix(fmt): ensure commasep breaks with final trailing cmnt (#12031)

* fix(fmt): refine logic over comments between uninformed commasep (#12055)

* fix(anvil): set envelope for non deposit tx in debug tracers (#12080)

* chore: bump v1.4.1 (#12083)

chore: bumpt v1.4.1

* fix(fmt): don't normalize single-line non-doc block cmnts (#12078)

* fix: don't normalize single-line non-doc block cmnts

* fix: preserve consecutive whitespaces

* fix: use byte length instead of char count

---------

Co-authored-by: 0xrusowsky <[email protected]>
@grandizzy grandizzy self-assigned this Oct 20, 2025
@jenpaff jenpaff moved this from Done to Completed in Foundry Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

3 participants