chore(deps): bump solar, compilers #11371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're calling this from inside a session, so the nested session inside of Graph::resolve will panic. Let's see if we can just remove the graph call here.
DaniPopes
commented
Aug 20, 2025
0xrusowsky
reviewed
Aug 21, 2025
Comment on lines
+115
to
+123
| let mut compiler = linter.init(); | ||
| compiler.enter_mut(|compiler| -> Result<()> { | ||
| let mut pcx = compiler.parse(); | ||
| configure_pcx(&mut pcx, &config, Some(&project), Some(&input))?; | ||
| pcx.parse(); | ||
| let _ = compiler.lower_asts(); | ||
| Ok(()) | ||
| })?; | ||
| linter.lint(&input, &mut compiler); |
DaniPopes
requested review from
klkvr,
mattsse,
grandizzy,
yash-atreya,
zerosnacks and
onbjerg
as code owners
DaniPopes
added a commit
to paradigmxyz/solar
that referenced
this pull request
Aug 22, 2025
Introduce `solar_sema::Compiler`. This is a unified API for the full compiler pipeline, as well as encapsulating the `enter(|| _)` requirement by only allowing access to the context when inside of the closure. See the HIR example and tests for the usage diff. Migrations: - foundry-compilers foundry-rs/compilers#300 - foundry: foundry-rs/foundry#11371 Closes #370.
onbjerg
previously approved these changes
Aug 22, 2025
mattsse
approved these changes
Aug 25, 2025
0xrusowsky
approved these changes
Aug 26, 2025
3 tasks
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceParsercompilers#300Unblocks #11307.