chore: improve bash script for release #2396
Conversation
| set -e | ||
|
|
||
| export DEPLOY_BRANCH=${DEPLOY_BRANCH:-development} | ||
| export PUBLISH_BRANCH=${PUBLISH_BRANCH:-master} |
There was a problem hiding this comment.
Use this. We can override this from environment variables
There was a problem hiding this comment.
ok let me add export to the conditions
| [[ $TRAVIS_PULL_REQUEST =~ ^(false)$ && $TRAVIS_REPO_SLUG =~ ^(fossasia/open-event-attendee-android)$ && $TRAVIS_BRANCH =~ ^(development|master)$ ]] && DEV_OR_MASTER_BUILD=true || DEV_OR_MASTER_BUILD=false | ||
| [[ $TRAVIS_BRANCH =~ ^(master)$ && $TRAVIS_REPO_SLUG =~ ^(fossasia/open-event-attendee-android)$ && $TRAVIS_PULL_REQUEST_SLUG =~ ^(fossasia/open-event-attendee-android)$ ]] && PR_FOR_RELEASE=true || PR_FOR_RELEASE=false | ||
|
|
||
| if [ "$TRAVIS_PULL_REQUEST" != "false" -o "$TRAVIS_REPO_SLUG" != "fossasia/open-event-attendee-android" ] || ! [ "$TRAVIS_BRANCH" == "$DEPLOY_BRANCH" -o "$TRAVIS_BRANCH" == "$PUBLISH_BRANCH" ]; then |
There was a problem hiding this comment.
The previous code is more readable, modify yours like this
There was a problem hiding this comment.
great, let me try to break the conditions down
adityastic
force-pushed
the
patch-2395
branch
from
ae436ea to
62a5d13
Compare
|
@iamareebjamal I've added export to both the major conditions so that they can be overridden with travis if you want. I've also broke down the conditions more precisely. Please have a look |
adityastic
force-pushed
the
patch-2395
branch
from
62a5d13 to
bd0c726
Compare
| [[ $TRAVIS_REPO_SLUG =~ ^(fossasia/open-event-attendee-android)$ ]] && IS_FOSS_SLUG=true || IS_FOSS_SLUG=false | ||
| [[ $TRAVIS_PULL_REQUEST_SLUG =~ ^(fossasia/open-event-attendee-android)$ ]] && IS_FOSS_PR=true || IS_FOSS_PR=false | ||
| [[ $TRAVIS_BRANCH =~ ^(development|master)$ && $IS_FOSS_SLUG ]] && BRANCH_DEPLOYORDEV=true || BRANCH_DEPLOYORDEV=false | ||
| [[ $TRAVIS_BRANCH =~ ^(master)$ && $IS_FOSS_SLUG ]] && IS_PUBLISH_BRANCH=true || IS_PUBLISH_BRANCH=false |
There was a problem hiding this comment.
Why not IS_PUBLISH_BRANCH = [[ $TRAVIS_BRANCH =~ ^(master)$ && $IS_FOSS_SLUG ]]
There was a problem hiding this comment.
no, conditional assignments don't work like this in bash. This was my first thought as well, but unfortunately.
adityastic
force-pushed
the
patch-2395
branch
3 times, most recently
from
4cd09fe to
9e0110d
Compare
adityastic
force-pushed
the
patch-2395
branch
from
9e0110d to
5bac919
Compare
adityastic
force-pushed
the
patch-2395
branch
from
5bac919 to
f50d53d
Compare
adityastic
force-pushed
the
patch-2395
branch
from
f50d53d to
639e0f8
Compare
adityastic
force-pushed
the
patch-2395
branch
3 times, most recently
from
6333049 to
a4ce534
Compare
adityastic
force-pushed
the
patch-2395
branch
from
a4ce534 to
fa4aa47
Compare
iamareebjamal
left a comment
iamareebjamal
left a comment
There was a problem hiding this comment.
Approving for now as I don't have much time nowadays
|
@iamareebjamal I'll look into possiblities and get back to you if I found a nice workaround |
|
git release is failing after fastlane release https://travis-ci.org/fossasia/open-event-attendee-android/builds/623111500?utm_source=github_status&utm_medium=notification |
|
@iamareebjamal sure, just give me a moment |
Signed-off-by: rcs10 <[email protected]>
2 participants
Fixes #2395