fix: Improve invalid fields #2244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
reviewed
Aug 5, 2019
app/src/main/java/org/fossasia/openevent/general/attendees/AttendeeViewHolder.kt
Outdated
Show resolved
Hide resolved
nikit19
reviewed
Aug 5, 2019
app/src/main/java/org/fossasia/openevent/general/speakercall/EditSpeakerFragment.kt
Outdated
Show resolved
Hide resolved
Details: - Check all invalid fields and show errors on all fields Fixes: #2239
liveHarshit
approved these changes
Aug 8, 2019
liveHarshit
pushed a commit
to liveHarshit/open-event-attendee-android
that referenced
this pull request
Aug 11, 2019
Details: - Check all invalid fields and show errors on all fields Fixes: fossasia#2239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fixes: #2239
Screenshots for the change:
