Skip to content

fix: Apply new discount code routing #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2019
Merged

fix: Apply new discount code routing #2204

merged 1 commit into from
Aug 3, 2019

Conversation

@anhanh11001
Copy link
Contributor

@anhanh11001 anhanh11001 commented Jul 28, 2019

Fixes: #2163

@auto-label auto-label bot added the fix label Jul 28, 2019
nikit19
nikit19 previously approved these changes Jul 28, 2019
View reviewed changes
liveHarshit
liveHarshit reviewed Jul 28, 2019
View reviewed changes
Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested?

@anhanh11001
Copy link
Contributor Author

anhanh11001 commented Jul 28, 2019

@liveHarshit not yet, I just change based on server PR. Do you already have an event with discount code or should I make a new one?

@liveHarshit
Copy link
Member

liveHarshit commented Jul 28, 2019

@liveHarshit not yet, I just change based on server PR. Do you already have an event with discount code or should I make a new one?

Yes but it's outdated. You need to create a new one.

@liveHarshit
Copy link
Member

liveHarshit commented Aug 1, 2019

Have you tested it, or I can test it?

@anhanh11001
Copy link
Contributor Author

anhanh11001 commented Aug 2, 2019 •
edited by unfurl-links bot
Loading

Yes, it is not working. @liveHarshit

@prateekj117 is this a correct endpoint:
https://api.eventyay.com/event/954/discount-code/DISS7

I have followed the change in your PR but this throw 404 error as requested URL not found on server. Or is it only updated in the debug mode?

prateekj117
prateekj117 reviewed Aug 2, 2019
View reviewed changes
app/src/main/java/org/fossasia/openevent/general/discount/DiscountApi.kt Outdated

@GET("discount-codes/{code}?include=event,tickets")
fun getDiscountCodes(@Path("code") code: String, @Query("filter") filter: String): Single<DiscountCode>
@GET("event/{eventId}/discount-code/{code}?include=event,tickets")
Copy link
Member

@prateekj117 prateekj117 Aug 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anhanh11001 It's /events/{eventId}/discount-codes/{code}.

@prateekj117
Copy link
Member

prateekj117 commented Aug 2, 2019

@anhanh11001 No, it's wrong. Correct endpoint would be: https://api.eventyay.com/events/954/discount-codes/DISS7.

@iamareebjamal
Copy link
Member

iamareebjamal commented Aug 2, 2019 •
edited by unfurl-links bot
Loading

https://api.eventyay.com/v1/events/954/discount-codes/DISS7

@anhanh11001
Copy link
Contributor Author

anhanh11001 commented Aug 3, 2019

It's working now

liveHarshit
liveHarshit reviewed Aug 3, 2019
View reviewed changes
app/build.gradle Outdated
buildConfigField "String", "DEFAULT_BASE_URL", '"https://open-event-api-dev.herokuapp.com/v1/"'
buildConfigField "String", "DEFAULT_BASE_URL", '"https://api.eventyay.com/v1/"'

// buildConfigField "String", "DEFAULT_BASE_URL", '"https://open-event-api-dev.herokuapp.com/v1/"'
Copy link
Member

@liveHarshit liveHarshit Aug 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Copy link
Contributor Author

@anhanh11001 anhanh11001 Aug 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@iamareebjamal iamareebjamal merged commit 9a3eb89 into fossasia:development Aug 3, 2019
@anhanh11001 anhanh11001 deleted the 2163_change_discount_code branch August 5, 2019 17:25
liveHarshit pushed a commit to liveHarshit/open-event-attendee-android that referenced this pull request Aug 11, 2019
@anhanh11001 @liveHarshit
fix: Apply new discount code routing (fossasia#2204)
3e27fa6 
Fixes: fossasia#2163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+3 more reviewers

@liveHarshit liveHarshit liveHarshit left review comments

@prateekj117 prateekj117 prateekj117 left review comments

@nikit19 nikit19 nikit19 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change endpoint for discount and access code

5 participants

@anhanh11001 @liveHarshit @prateekj117 @iamareebjamal @nikit19