feat: Verify email with app #2037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveHarshit
changed the title
anhanh11001
reviewed
Jul 1, 2019
| .nonNull() | ||
| .observe(viewLifecycleOwner, Observer { | ||
| rootView.snackbar(it) | ||
| profileViewModel.syncProfile() |
Member
Author
There was a problem hiding this comment.
Okay, it's duplicate. Removing.
anhanh11001
reviewed
Jul 1, 2019
Contributor
anhanh11001
left a comment
anhanh11001
left a comment
There was a problem hiding this comment.
Rest is good I think
anhanh11001
previously approved these changes
Jul 1, 2019
ShridharGoel
previously approved these changes
Jul 1, 2019
app/build.gradle
Outdated
| debug { | ||
| buildConfigField "String", "DEFAULT_BASE_URL", '"https://open-event-api-dev.herokuapp.com/v1/"' | ||
| buildConfigField "String", "FRONTEND_URL", '"https://fossasia.github.io/open-event-frontend/"' | ||
| buildConfigField "String", "FRONTEND_URL", '"https://open-event-fe.netlify/"' |
Member
There was a problem hiding this comment.
Duplicate, just use FRONTEND_HOST
liveHarshit
dismissed stale reviews from ShridharGoel and anhanh11001
via
a9ea082
| buildConfigField "String", "MAPBOX_KEY", '"'+MAPBOX_KEY+'"' | ||
| buildConfigField "String", "STRIPE_API_KEY", '"'+STRIPE_API_TOKEN+'"' | ||
| resValue "string", "FRONTEND_HOST", "fossasia.github.io/open-event-frontend" | ||
| resValue "string", "FRONTEND_HOST", "open-event-fe.netlify.com" |
Member
There was a problem hiding this comment.
Why not buildConfigField? It's static, it's constant, requires no context
Member
Author
There was a problem hiding this comment.
Cannot use in the manifest file for handle app link data.
iamareebjamal
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1926