Skip to content

feat: Update read status and apply filter for notifications #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2019
Merged

feat: Update read status and apply filter for notifications #1998

merged 1 commit into from
Jun 29, 2019

Conversation

@liveHarshit
Copy link
Member

@liveHarshit liveHarshit commented Jun 23, 2019 •
edited
Loading

Fixes #1984

@liveHarshit liveHarshit mentioned this pull request Jun 24, 2019
Closed
@liveHarshit liveHarshit changed the title [WIP] feat: Update notification feat: Update read status and apply filter for notifications Jun 28, 2019
@auto-label auto-label bot added the feature label Jun 28, 2019
@liveHarshit
Copy link
Member Author

liveHarshit commented Jun 28, 2019

@liveHarshit liveHarshit requested a review from anhanh11001 June 28, 2019 09:13
@liveHarshit liveHarshit force-pushed the 1984 branch 2 times, most recently from 3b460c6 to d3c88e8 Compare June 28, 2019 12:39
iamareebjamal
iamareebjamal reviewed Jun 28, 2019
View reviewed changes
app/src/main/java/org/fossasia/openevent/general/notification/Notification.kt Outdated
val message: String? = null,
val receivedAt: String? = null,
val isRead: Boolean? = null,
@JsonRawValue var isRead: Boolean = false,
Copy link
Member

@iamareebjamal iamareebjamal Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect solution

Copy link
Member Author

@liveHarshit liveHarshit Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please suggest the solution because KebabCaseStrategy is skipping the is word

Copy link
Member

@iamareebjamal iamareebjamal Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JsonProperty

Copy link
Member Author

@liveHarshit liveHarshit Jun 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JsonProperty

I have tried it. Not working -

@JsonProperty("is-read")
    var isRead: Boolean = false,

Still sending read

Copy link
Member

@iamareebjamal iamareebjamal Jun 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@get:JsonProperty("is_something")
@param:JsonProperty("is_something")

https://stackoverflow.com/a/55100741/3309666

Copy link
Member Author

@liveHarshit liveHarshit Jun 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param not working, @get:JsonProperty is working fine, Updated 👍

@nikit19 nikit19 merged commit 5548e3f into fossasia:development Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@anhanh11001 anhanh11001 Awaiting requested review from anhanh11001

+1 more reviewer

@nikit19 nikit19 nikit19 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update notification section

3 participants

@liveHarshit @iamareebjamal @nikit19