fix: Check for device location settings #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
reviewed
Jun 18, 2019
app/src/main/java/org/fossasia/openevent/general/search/SearchLocationFragment.kt
Outdated
Show resolved
Hide resolved
nikit19
previously approved these changes
Jun 19, 2019
adityastic
previously approved these changes
Jun 19, 2019
iamareebjamal
requested changes
Jun 19, 2019
| } | ||
| } | ||
|
|
||
| fun checkLocationSettings(context: Context): Boolean { |
Member
There was a problem hiding this comment.
checkLocationSettings is a verb, hence, this function should return nothing
If you want this to return boolean, rename to isLocationEnabled
anhanh11001
approved these changes
Jun 19, 2019
iamareebjamal
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1971