fix: Revalidate profile from API #1918
Conversation
| } | ||
| } | ||
|
|
||
| fun updateProfile(id: Long = authHolder.getId()): Single<User> { |
There was a problem hiding this comment.
Where is it updating the profile?
There was a problem hiding this comment.
Inserting in the database and updating in the profile fragment without showing progress.
There was a problem hiding this comment.
That's fetching/saving/syncing
Updating is if you send some data on server to update/
There was a problem hiding this comment.
Not getting it. Mean retrieving information from the server and updating the same on the server.
There was a problem hiding this comment.
come data
Data coming from API?
There was a problem hiding this comment.
But here we are updating User name only in edit profile fragment which is already updating on server. And now syncing the data is required because profile verification is working from the server side.
There was a problem hiding this comment.
Why is the name of method updateProfile?
There was a problem hiding this comment.
Oh got it. It shouldn't. It can be sync or fetch profile.
liveHarshit
dismissed stale reviews from adityastic, anhanh11001, and nikit19
via
bba0d28
6 participants
Fixes #1904