feat: Add checking required fields #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: - Add checking required fields - Add hint for required fields Fixes: #1857
liveHarshit
reviewed
May 30, 2019
Member
liveHarshit
left a comment
liveHarshit
left a comment
There was a problem hiding this comment.
Are you sure that these fields are must, because I don't find the same in front-end?
Contributor
Author
|
@liveHarshit I think so, which part of it do you find not necessary. For billing information, I only check it when the checkbox is ticked |
Member
Okay then. 👍 |
liveHarshit
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fixes: #1857
Screenshots for the change:
