feat: Show date and time wise check-in #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhanh11001
reviewed
May 30, 2019
Contributor
anhanh11001
left a comment
anhanh11001
left a comment
There was a problem hiding this comment.
layout id/checkInLayout and layout id/notCheckInLayout is the same right? So instead of toggling the visibility of these layouts, why don't you make it a single layout and change the content (text, circle color) inside it
Member
Author
The code will get complicated because in that case, I need to change text color, set background tint and change text programmatically for each condition. So, IMO it's better to set design in layout resources file and make the code simple. |
Contributor
|
Well, that makes sense to me |
anhanh11001
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1845
Screenshots for the change: