Skip to content

fix: Fix shared element transition problems for older version #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2019
Merged

fix: Fix shared element transition problems for older version #1807

merged 1 commit into from
May 21, 2019

Conversation

@anhanh11001
Copy link
Contributor

@anhanh11001 anhanh11001 commented May 21, 2019 •
edited by iamareebjamal
Loading

Detail:

  • Only set shared element transition for API version >= 26
  • Remove delay for loading image

Fixes: #1805
Fixes #1804

Discussion on #1799

@anhanh11001
Summary: Fix shared element transition problem for older version
f94ba46 
Detail:
- Only set shared element transition for API version >= 26
- Remove delay for loading image

Fixes: #1805, #1804
@auto-label auto-label bot added the fix label May 21, 2019
@liveHarshit
Copy link
Member

liveHarshit commented May 21, 2019

What about PR #1799

@anhanh11001
Copy link
Contributor Author

anhanh11001 commented May 21, 2019

What about PR #1799

I still keep it for issue #1798, I split the two as I think it is not a good habit to make 1 PR for multiple issues, and recently I do it quite a lot...

@iamareebjamal iamareebjamal merged commit 22b76ab into fossasia:development May 21, 2019
@anhanh11001 anhanh11001 mentioned this pull request May 21, 2019
Merged
@anhanh11001 anhanh11001 deleted the shared_element_fix branch June 20, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+1 more reviewer

@liveHarshit liveHarshit liveHarshit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

App is showing delay while navigating to events details due to transition Likes section is displaying Events fragment

3 participants

@anhanh11001 @liveHarshit @iamareebjamal