fix: Updating feedback section after making new one #1747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
previously approved these changes
May 11, 2019
iamareebjamal
requested changes
May 13, 2019
app/src/main/res/values/strings.xml
Outdated
| <string name="user_update_success_message">User updated successfully!</string> | ||
| <string name="error_fetching_event_sponsors_message">Error fetching sponsors for event</string> | ||
| <string name="error_fetching_event_sessions_message">Error fetching sessions for event</string> | ||
| <string name="error_fetching_event_speakers_message">Error fetching speakers for event</string> |
Member
There was a problem hiding this comment.
Use one placeholder string and reuse it
Contributor
Author
There was a problem hiding this comment.
updated. please review
Detail: - Add livedata object to observe new submitted feedback. - Extract string + fix small bugs Fixes: #1746
Contributor
Author
|
@iamareebjamal updated |
iamareebjamal
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail:
Fixes: #1746
Screenshots for the change:
