refactor: Use Kotlin only safe args plugin #1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Build is failing |
Fixes fossasia#1612. Uses the kotlin version of the safe args plugin to get rid of the builder pattern when creating the arguments object for a destination.
haroldadmin
force-pushed
the
safe-args-kotlin
branch
from
aec4848 to
5373241
Compare
Contributor
Author
|
@liveHarshit @nikit19 I've fixed the build issue. Please take a look at the changes. |
iamareebjamal
approved these changes
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the kotlin version of the safe args plugin to
get rid of the builder pattern when creating the arguments object
for a destination.
Fixes #1612.
Changes: Migrates the project to use the kotlin safe args plugin