Skip to content

Conversation

@RotBolt
Copy link

@RotBolt RotBolt commented Apr 15, 2019

Fixes #1602

Changes:

  • stripHtml() to remove Html tags before putting text in intent
  • remove redundant qualifiers
  • !value.isEmpty() -> value.isNotEmpty()

Screenshots for the change:

@RotBolt RotBolt changed the title strop raw html fix: strip raw html evenr description before sharing Apr 15, 2019
@auto-label auto-label bot added the fix label Apr 15, 2019
angmas1
angmas1 previously approved these changes Apr 15, 2019
Copy link
Member

@nikit19 nikit19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes

@RotBolt
Copy link
Author

RotBolt commented Apr 16, 2019

Sorry for the delay . Currently AFK . would surely get to work Tomorrow . will rebase this

iamareebjamal
iamareebjamal previously approved these changes Apr 16, 2019
@RotBolt
Copy link
Author

RotBolt commented Apr 17, 2019

@nikit19 I have updated

iamareebjamal
iamareebjamal previously approved these changes Apr 17, 2019
@iamareebjamal
Copy link
Member

Build is failing

@aggarwalpulkit596
Copy link
Contributor

run ./gradlew spotlessApply

Co-Authored-By: theLimitBreaker <[email protected]>
@RotBolt
Copy link
Author

RotBolt commented Apr 17, 2019

I have updated . @aggarwalpulkit596 thanks Also the problem was ordering nullToEmpty and stripHtml. Yesterday I just directly apllied suggestion as I was AFK.

@iamareebjamal iamareebjamal merged commit b55e30d into fossasia:development Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raw HTML is being sent in EventDescription while sharing event details

5 participants