feat: Add Speakers Section #1606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarwalpulkit596
force-pushed
the
speakers
branch
2 times, most recently
from
1fcfead to
c076d7c
Compare
aggarwalpulkit596
changed the title
aggarwalpulkit596
force-pushed
the
speakers
branch
from
c076d7c to
1e4031f
Compare
Contributor
Author
|
@iamareebjamal @liveHarshit please review |
liveHarshit
reviewed
Apr 14, 2019
Member
liveHarshit
left a comment
liveHarshit
left a comment
There was a problem hiding this comment.
IMO, no need to store in offline database
Member
|
This can be stored |
Contributor
Author
|
We'll be a needing a speakerswithevent table |
Contributor
Author
|
Because same speaker can be in two different events and it will make things complicated |
Member
|
It won't |
Contributor
Author
aggarwalpulkit596
left a comment
aggarwalpulkit596
left a comment
There was a problem hiding this comment.
It won't
@iamareebjamal so should i use the table i created or make it work like event-topic
app/src/main/java/org/fossasia/openevent/general/speakers/SpeakerWithEvent.kt
Show resolved
Hide resolved
aggarwalpulkit596
force-pushed
the
speakers
branch
from
efc88ad to
f8a13e7
Compare
Contributor
Author
|
I tried to save information in a 3rd table and accordingly get back result as list of live data instead of flowable list i was able to save them but couldn't figure how to return that saved data |
app/src/main/java/org/fossasia/openevent/general/event/EventService.kt
Outdated
Show resolved
Hide resolved
Member
|
Will take a look |
Contributor
Author
|
@iamareebjamal any update ? |
aggarwalpulkit596
force-pushed
the
speakers
branch
from
f8a13e7 to
df0c165
Compare
Contributor
Author
|
@liveHarshit please review now |
Contributor
Author
|
@liveHarshit review this one as well |
Member
|
lgtm |
iamareebjamal
changed the title
app/src/main/java/org/fossasia/openevent/general/speakers/Speaker.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/speakers/Speaker.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/speakers/Speaker.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/speakers/Speaker.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/speakers/SpeakerDao.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/speakers/SpeakerDao.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/speakers/SpeakerWithEventDao.kt
Outdated
Show resolved
Hide resolved
aggarwalpulkit596
force-pushed
the
speakers
branch
2 times, most recently
from
9aeb6ce to
aa0735b
Compare
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsViewModel.kt
Show resolved
Hide resolved
aggarwalpulkit596
force-pushed
the
speakers
branch
from
aa0735b to
86eb5e6
Compare
Contributor
Author
|
@iamareebjamal updated |
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
aggarwalpulkit596
force-pushed
the
speakers
branch
from
86eb5e6 to
cfcbb25
Compare
aggarwalpulkit596
changed the title
aggarwalpulkit596
force-pushed
the
speakers
branch
from
cfcbb25 to
2f291c7
Compare
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsViewModel.kt
Show resolved
Hide resolved
aggarwalpulkit596
force-pushed
the
speakers
branch
from
2f291c7 to
4ad61c3
Compare
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsViewModel.kt
Show resolved
Hide resolved
aggarwalpulkit596
force-pushed
the
speakers
branch
from
4ad61c3 to
7fd306c
Compare
Member
|
Everything working as expected? |
Contributor
Author
|
@iamareebjamal yup |
iamareebjamal
previously approved these changes
Apr 17, 2019
| } | ||
|
|
||
| fun loadEventSpeakers(id: Long): LiveData<List<Speaker>> { | ||
| val speakerList = speakerService.fetchSpeakersFromDb(id) |
Member
There was a problem hiding this comment.
Store this in the ViewModel. What use is this variable, you're just returning it
nikit19
reviewed
Apr 17, 2019
app/src/main/java/org/fossasia/openevent/general/speakers/SpeakerService.kt
Show resolved
Hide resolved
aggarwalpulkit596
force-pushed
the
speakers
branch
from
2a8bffe to
e0ad13b
Compare
Contributor
Author
|
@iamareebjamal updated |
Contributor
Author
|
@nikit19 please review now |
Member
|
schema JSON is not updated |
aggarwalpulkit596
force-pushed
the
speakers
branch
from
e0ad13b to
44000c2
Compare
Contributor
Author
|
@iamareebjamal updated JSON Schema and resolved conflicts |
iamareebjamal
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1604
Changes:Added Speakers section in Event Details
[WIP]Add a speaker page
Screenshots for the change:
