fix: default currency in case of no currency #1599
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarwalpulkit596
force-pushed
the
currencyFix
branch
from
8e57143 to
aa9d2f5
Compare
|
|
||
| currency = Currency.getInstance(event.paymentCurrency).symbol | ||
| event.paymentCurrency.let { | ||
| currency = Currency.getInstance(it ?: "INR").symbol |
aggarwalpulkit596
force-pushed
the
currencyFix
branch
from
aa9d2f5 to
64bf581
Compare
Contributor
Author
|
@iamareebjamal updated |
iamareebjamal
approved these changes
Apr 13, 2019
iamareebjamal
requested changes
Apr 13, 2019
Member
iamareebjamal
left a comment
iamareebjamal
left a comment
There was a problem hiding this comment.
currency = Currency.getInstance(event.paymentCurrency ?: "USD").symbol
aggarwalpulkit596
force-pushed
the
currencyFix
branch
from
64bf581 to
d619451
Compare
Contributor
Author
|
@iamareebjamal updated |
iamareebjamal
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1596
Changes: Default INR currency in case of no currency passed