feat: add external event url menu option in EventDetailsFragment #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
IMO, hiding it is a better option. |
Contributor
Author
|
@liveHarshit changes made |
liveHarshit
reviewed
Apr 2, 2019
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt
Show resolved
Hide resolved
Fixes: fossasia#1505 Changes: - Added a menu option to EventDetailsFragment to navigate to the external event url for the event - If the external URL is null, then the menu option is hidden Additional Changes: - Modified the methods used to mark favorite icon to be consistent with above added features
Contributor
Author
|
@liveHarshit removed extra lines and squashed commits |
addiegupta
commented
Apr 2, 2019
| if (eventShare.externalEventUrl == null) { | ||
| menu.findItem(R.id.open_external_event_url).isVisible = false | ||
| } | ||
| setFavoriteIconFilled(eventShare.favorite) |
Contributor
Author
There was a problem hiding this comment.
@nikit19 this statement is also to be executed only if eventShare has been initialised
nikit19
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1505
Changes:
Screenshots for the change:
Additional details:
The option has been titled 'Open External Event URL' to maintain consistency with the eventyay frontend e.g. check the option on the right side at https://eventyay.com/e/a1fcaa21/coc/
Instead of removing the menu item if the URL is null, I have chosen to disable the option because removing the item requires calling
invalidateOptionsMenu()which will force the menu options to be prepared once again. This resets the favorite icon status also hence the favorite icon will have to be set again. Hence to avoid this complexity I have simply disabled it. If suggested, I can use this approach to remove the option altogether when the URL is nullEDIT: Updated GIF after now hiding option when URL is null
Will squash commits once this gets approved