feat: add Event Location #1498

aggarwalpulkit596 · 2019-04-01T08:21:31Z

Fixes #1421

Changes: Added Popular Location in search location fragment

Screenshots for the change:

angmas1 · 2019-04-01T08:23:34Z

Add screenshot

aggarwalpulkit596 · 2019-04-01T08:24:51Z

@angmas1 i haven't completed the pr as of yet that's why i added a WIP tag

angmas1 · 2019-04-01T08:36:27Z

@angmas1 i haven't completed the pr as of yet that's why i added a WIP tag

Okay, sorry continue working.

aggarwalpulkit596 · 2019-04-01T18:46:37Z

@iamareebjamal a little bit of help here as autocompletefragment requires match parent layout and i'm not able to add it with a list view any suggestions

iamareebjamal · 2019-04-01T20:46:10Z

I don't understand

iamareebjamal · 2019-04-02T10:31:16Z

This is not correct UI. You'll have to change it's behavior

aggarwalpulkit596 · 2019-04-03T08:07:36Z

@iamareebjamal this can be merged after mapbox have been removed

angmas1 · 2019-04-03T13:22:13Z

UI looks bad, I think we should stop showing popular cities list once user starts typing.

aggarwalpulkit596 · 2019-04-03T14:21:02Z

Thing's would be different after removing the mapbox sdk autocomplete textview would be removed and also in terms of UI it is pretty much similar to Eventbrite

aggarwalpulkit596 · 2019-04-03T16:16:30Z

@iamareebjamal updated

aggarwalpulkit596 · 2019-04-03T16:47:05Z

@iamareebjamal i've refractor constraint layout to linear layout as there is no use of constraint layout for this layout and we should avoid using constraint layout as it much more expensive than linear layout.

iamareebjamal · 2019-04-03T17:19:49Z

Peer reviews first

aggarwalpulkit596 · 2019-04-03T17:26:20Z

@liveHarshit please review

app/schemas/org.fossasia.openevent.general.OpenEventDatabase/1.json

aggarwalpulkit596 · 2019-04-04T08:03:36Z

@liveHarshit updated

aggarwalpulkit596 · 2019-04-06T14:38:19Z

@iamareebjamal i messed up the pr a little bit should i make seperate pr because i'm not able to fix it

iamareebjamal · 2019-04-06T16:00:20Z

You can create a new branch and force push it on this branch

aggarwalpulkit596 · 2019-04-06T16:24:37Z

@iamareebjamal it has been fixed please review

iamareebjamal · 2019-04-06T20:46:31Z

app/src/main/java/org/fossasia/openevent/general/event/EventService.kt

+            else
+                eventLocationApi.getEventLocation()
+                    .map {
+                        eventLocationDao.insertEventLocations(it)


No need to save in DB

aggarwalpulkit596 · 2019-04-07T04:31:47Z

@iamareebjamal updated

aggarwalpulkit596 · 2019-04-07T20:31:54Z

@iamareebjamal fixed conflicts

app/src/test/java/org/fossasia/openevent/general/DependencyTest.kt

aggarwalpulkit596 · 2019-04-08T10:22:12Z

I'm getting an error that dryRun has bee deprecated

aggarwalpulkit596 · 2019-04-08T13:20:20Z

@iamareebjamal please review

iamareebjamal · 2019-04-08T15:40:30Z

app/src/main/java/org/fossasia/openevent/general/event/location/EventLocation.kt

+    @Id(LongIdHandler::class)
+    val id: Long?,
+    val name: String?,
+    val slug: String?


Why are these nullable?

I can intialize them with empty string also i just followed the pattern which was found in most of the data classes

@iamareebjamal should i initialize with them empty string instead of being nullable type?

No, make them non nullable without intializers. Tell me if they don't work

aggarwalpulkit596 · 2019-04-09T03:34:37Z

@iamareebjamal updated and it is working even without being of type and also in JSON API responses the id are usually not nullable so should i refractor all them in a separate PR

aggarwalpulkit596 · 2019-04-10T10:03:36Z

@iamareebjamal updated

aggarwalpulkit596 force-pushed the popularLocations branch from ce11e6e to 7336b23 Compare April 1, 2019 18:43

aggarwalpulkit596 changed the title ~~[WIP]feat: add Event Location[skip ci]~~ feat: add Event Location Apr 1, 2019

aggarwalpulkit596 force-pushed the popularLocations branch from 7336b23 to 80deb58 Compare April 2, 2019 02:57

fossasia deleted a comment Apr 2, 2019

iamareebjamal added the feature label Apr 2, 2019

iamareebjamal added this to the v0.2.0 milestone Apr 2, 2019

aggarwalpulkit596 mentioned this pull request Apr 2, 2019

Tremendous increase in app size #1515

Closed

aggarwalpulkit596 force-pushed the popularLocations branch 2 times, most recently from d5aa41b to a0ec2d1 Compare April 3, 2019 16:14

aggarwalpulkit596 force-pushed the popularLocations branch from a0ec2d1 to 7aecd97 Compare April 3, 2019 16:39

aggarwalpulkit596 force-pushed the popularLocations branch from 7aecd97 to 679c366 Compare April 3, 2019 17:05

liveHarshit reviewed Apr 4, 2019

View reviewed changes

app/schemas/org.fossasia.openevent.general.OpenEventDatabase/1.json Outdated Show resolved Hide resolved

app/schemas/org.fossasia.openevent.general.OpenEventDatabase/1.json Outdated Show resolved Hide resolved

aggarwalpulkit596 force-pushed the popularLocations branch from 679c366 to e3f51f5 Compare April 4, 2019 08:03

aggarwalpulkit596 force-pushed the popularLocations branch 2 times, most recently from 8a373c6 to be4a014 Compare April 4, 2019 16:01

aggarwalpulkit596 force-pushed the popularLocations branch from ca7e12d to 8934949 Compare April 6, 2019 14:11

aggarwalpulkit596 force-pushed the popularLocations branch from 8934949 to ba77782 Compare April 6, 2019 14:48

fossasia deleted a comment Apr 6, 2019

iamareebjamal reviewed Apr 6, 2019

View reviewed changes

aggarwalpulkit596 force-pushed the popularLocations branch from c2b89da to c6fc76c Compare April 7, 2019 04:31

iamareebjamal previously approved these changes Apr 7, 2019

View reviewed changes

aggarwalpulkit596 dismissed iamareebjamal’s stale review via e1fa4d4 April 7, 2019 20:31

aggarwalpulkit596 force-pushed the popularLocations branch from c6fc76c to e1fa4d4 Compare April 7, 2019 20:31

iamareebjamal previously approved these changes Apr 7, 2019

View reviewed changes

aggarwalpulkit596 dismissed iamareebjamal’s stale review via cd326b9 April 7, 2019 21:02

aggarwalpulkit596 force-pushed the popularLocations branch from 3f32d40 to cd326b9 Compare April 7, 2019 21:02

iamareebjamal reviewed Apr 8, 2019

View reviewed changes

app/src/test/java/org/fossasia/openevent/general/DependencyTest.kt Outdated Show resolved Hide resolved

aggarwalpulkit596 force-pushed the popularLocations branch from 91303ce to 4b8f7d4 Compare April 8, 2019 13:20

iamareebjamal reviewed Apr 8, 2019

View reviewed changes

aggarwalpulkit596 force-pushed the popularLocations branch from 4b8f7d4 to 08d4967 Compare April 9, 2019 03:33

iamareebjamal previously approved these changes Apr 9, 2019

View reviewed changes

feat: add Event Locations

1237d38

aggarwalpulkit596 dismissed iamareebjamal’s stale review via 1237d38 April 10, 2019 10:03

aggarwalpulkit596 force-pushed the popularLocations branch from c00d43f to 1237d38 Compare April 10, 2019 10:03

iamareebjamal approved these changes Apr 10, 2019

View reviewed changes

iamareebjamal merged commit 75180e7 into fossasia:development Apr 10, 2019

feat: add Event Location #1498

feat: add Event Location #1498

Uh oh!

Conversation

aggarwalpulkit596 commented Apr 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angmas1 commented Apr 1, 2019

Uh oh!

aggarwalpulkit596 commented Apr 1, 2019

Uh oh!

angmas1 commented Apr 1, 2019

Uh oh!

aggarwalpulkit596 commented Apr 1, 2019

Uh oh!

iamareebjamal commented Apr 1, 2019

Uh oh!

iamareebjamal commented Apr 2, 2019

Uh oh!

aggarwalpulkit596 commented Apr 3, 2019

Uh oh!

angmas1 commented Apr 3, 2019

Uh oh!

aggarwalpulkit596 commented Apr 3, 2019

Uh oh!

aggarwalpulkit596 commented Apr 3, 2019

Uh oh!

aggarwalpulkit596 commented Apr 3, 2019

Uh oh!

iamareebjamal commented Apr 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aggarwalpulkit596 commented Apr 3, 2019

Uh oh!

Uh oh!

Uh oh!

aggarwalpulkit596 commented Apr 4, 2019

Uh oh!

aggarwalpulkit596 commented Apr 6, 2019

Uh oh!

iamareebjamal commented Apr 6, 2019

Uh oh!

aggarwalpulkit596 commented Apr 6, 2019

Uh oh!

iamareebjamal Apr 6, 2019

Choose a reason for hiding this comment

Uh oh!

aggarwalpulkit596 commented Apr 7, 2019

Uh oh!

aggarwalpulkit596 commented Apr 7, 2019

Uh oh!

Uh oh!

aggarwalpulkit596 commented Apr 8, 2019

Uh oh!

aggarwalpulkit596 commented Apr 8, 2019

Uh oh!

iamareebjamal Apr 8, 2019

Choose a reason for hiding this comment

Uh oh!

aggarwalpulkit596 Apr 8, 2019

Choose a reason for hiding this comment

Uh oh!

aggarwalpulkit596 Apr 8, 2019

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

aggarwalpulkit596 commented Apr 9, 2019

Uh oh!

aggarwalpulkit596 commented Apr 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aggarwalpulkit596 commented Apr 1, 2019 •

edited

Loading

iamareebjamal commented Apr 3, 2019 •

edited

Loading