feat: Added Hindi Translations #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@iamareebjamal @nikit19 please review |
Contributor
Author
|
@iamareebjamal please review |
liveHarshit
approved these changes
Mar 20, 2019
Member
|
Many translations are wrong. It'll be worse for a person who is using hindi as a language option than seeing the strings in English. I think the same thing is true for other language translations. But I could verify only this because I understand Hindi. Internationalization is not our priority right now |
Contributor
Author
|
@iamareebjamal I'm not proficient in hindi, you can suggest changes |
Member
|
That's the point. Why add changes which are not required and wrong. Obviously I'm going to spend time reviewing and suggesting on other PRs solving actual issues |
Contributor
|
Well, there is a cool hack to translate the strings using google sheets. |
iamareebjamal
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1275
Changes: Added Hindi Translations to the app.