fix: horizontal search view doesn't take up whole screen #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: By default, max_width of search view is 320 for all devices so I changed to max_width of it to Int.MAX This resolve issue 959
liveHarshit
approved these changes
Mar 6, 2019
Member
|
This issue is not assigned to you. Please do not send PR without asking for work on the issue. |
Contributor
Author
|
@liveHarshit I'm really sorry about that, I will remember to ask first. I did see someone saying working on this but this issue is left for a long time while it's pretty simple to solve so I thought it's neglected. |
iamareebjamal
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: By default, max_width of search view is 320 for all devices so I changed to max_width of it to Int.MAX
Fixes #959
Screenshots for the change:
