fix: rewrote the source file extension REGEX #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex now allows for more failthul patterns to the input strings to be formed. In the future we should probably allow full regex expressions as inputs, as opposed to now, where we escape special characters. Fixes #300
gnikit
force-pushed
the
feat/generic-sources
branch
from
ab801e6 to
931fb55
Compare
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
==========================================
+ Coverage 86.96% 86.97% +0.01%
==========================================
Files 12 12
Lines 4571 4575 +4
==========================================
+ Hits 3975 3979 +4
Misses 596 596
|
v2 of pydantic introduces breaking changes, specifically Field() now returns a FieldInfo with the `annotation` field set to NonType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex now allows for more failthul patterns to the input strings
to be formed.
In the future we should probably allow full regex expressions as inputs,
as opposed to now, where we escape special characters.
Fixes #300