Issue #286: Fix wrong indentation of derived type #305
Conversation
Add division sign, allow spaces in values of parameters. Extend unittests with patameters variables
Trim trailing whitespaces. Modify one test and add one more parameter_val test with multiline definition.
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 86.98% 86.98%
=======================================
Files 12 12
Lines 4580 4581 +1
=======================================
+ Hits 3984 3985 +1
Misses 596 596
|
gnikit
left a comment
gnikit
left a comment
There was a problem hiding this comment.
Please don't change or invalidate existing tests for a modification.
None of the existing tests should have to change line numbers/column numbers.
You can add a test to demonstrate the issue that is being solved.
Also, please link to the corresponding Issue.
|
I am converting this to a draft. Please mark as ready for review when the PR is ready. |
|
@gnikit , Sorry, You are right, I turn back modified tests and add new one for current Issue. As I understood it's enough just to add new commit without any additional manipulations. |
gnikit
left a comment
gnikit
left a comment
There was a problem hiding this comment.
Please update with relevant comments and slim down the test case, to only test the unit of code introduced.
Also update the CHANGELOG, with a matching style and descriptions as the other entries under
Fixed.
gnikit
left a comment
gnikit
left a comment
There was a problem hiding this comment.
I updated the docstring, since they are used as unit tests.
I will merge once the checks pass.
2 participants
refuse spaces in middle of derived types, add one test