Skip to content

Conversation

@certik
Copy link
Member

@certik certik commented Dec 15, 2022

No description provided.

@certik certik requested a review from gnikit as a code owner December 15, 2022 21:21
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #252 (892540a) into master (14b2dde) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files          12       12           
  Lines        4556     4556           
=======================================
  Hits         3959     3959           
  Misses        597      597           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@gnikit gnikit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gnikit
Copy link
Member

gnikit commented Dec 17, 2022

One think I noticed, is that we don't have the roadmap for the LFortran LSP online yet. Let's comment out the:

Have a look at our roadmap (link) and consider contributing to our efforts (donations and contribution tasks link).

and uncomment it when we get around to having donation links, and a Roadmap/TODO list for that contributors can help with.

@gnikit gnikit merged commit e611a09 into fortran-lang:master Dec 17, 2022
@certik certik deleted the readme1 branch December 18, 2022 01:13
@certik
Copy link
Member Author

certik commented Dec 18, 2022

Perfect, thanks @gnikit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants