bug: incomplete submodule setting name to None #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submodule AST node was setting the name of the object to None instead of an empty string which caused havoc in all sorts of places. Fixes #233
gnikit
force-pushed
the
gnikit/issue233
branch
from
5ff731f to
fc61846
Compare
gnikit
force-pushed
the
gnikit/issue233
branch
from
7f5879f to
02da496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submodule AST node was setting the name of the
object to None instead of an empty string which caused
havoc in all sorts of places.
Fixes #233