Skip to content

chore: fix some minor issues in the comments #6511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025

Conversation

gopherorg
Copy link
Contributor

@gopherorg gopherorg commented Jun 27, 2025

Tracking issue

Why are the changes needed?

fix some minor issues in the comments

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request improves code documentation by updating function names in comments for better clarity. It addresses minor issues without changing any functionality.

Copy link

welcome bot commented Jun 27, 2025

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@kumare3
Copy link
Contributor

kumare3 commented Jun 27, 2025

LGTM

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.65%. Comparing base (19d04d5) to head (5081a67).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6511      +/-   ##
==========================================
- Coverage   58.66%   58.65%   -0.01%     
==========================================
  Files         938      938              
  Lines       71382    71382              
==========================================
- Hits        41873    41867       -6     
- Misses      26327    26333       +6     
  Partials     3182     3182              
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.19% <ø> (-0.03%) ⬇️
unittests-flytecopilot 39.56% <ø> (ø)
unittests-flytectl 64.72% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.07% <ø> (ø)
unittests-flytepropeller 54.83% <ø> (ø)
unittests-flytestdlib 64.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sovietaced
Copy link
Contributor

Will rerun that build job and see if we can get it green.

@Sovietaced Sovietaced merged commit 61b5b4a into flyteorg:master Jun 28, 2025
76 of 78 checks passed
Copy link

welcome bot commented Jun 28, 2025

Congrats on merging your first pull request! 🎉

@Sovietaced Sovietaced added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants