Add custom info field to ExternalResourceInfo #6115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new `FastTaskAssignment` message type to fast task protos, which is used to send actor assignment info to admin via task events.
While here I also hardened linting on our protos and updates existing protos to conform. This matches the restrictions we have in place in unionai/cloud/idl
- [x] Add and run unittests
- [x] Run locally and verify worker assignment info comes through in task events
```
❯ curl -s http://localhost:8088/api/v1/task_executions/flytesnacks/development/f0dcb5e7cae6d47acaf3/n0\?limit\=100 | jq '.taskExecutions[0].closure.metadata.externalResources'
[
{
"externalId": "",
"index": 0,
"retryAttempt": 0,
"phase": "UNDEFINED",
"cacheStatus": "CACHE_DISABLED",
"logs": [],
"customInfo": {
"assignedWorker": "example-2b377271ee80",
"environmentId": "flytesnacks_development_example_c183cb6c9868d96"
}
}
]
❯ curl -s http://localhost:8088/api/v1/task_executions/flytesnacks/development/f0dcb5e7cae6d47acaf3/n1\?limit\=100 | jq '.taskExecutions[0].closure.metadata.externalResources'
[
{
"externalId": "",
"index": 0,
"retryAttempt": 0,
"phase": "UNDEFINED",
"cacheStatus": "CACHE_DISABLED",
"logs": [],
"customInfo": {
"assignedWorker": "example-2b377271ee80",
"environmentId": "flytesnacks_development_example_c183cb6c9868d96"
}
}
]
```
One merged, bring to cloud. Will be a no-op initially, but we can use this in a few dependent tasks to surface logs or look up other fast task worker info.
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [ ] To be upstreamed to OSS
ref COR-1581
Add custom info field to ExternalResourceInfo
Adds a custom info field to `ExternalResourceInfo`. This is an extension of the [ExternalId](https://github.com/unionai/flyte/blob/2b6dfcaedab7ed6a7606d1434211086d064c6560/flyteidl/protos/flyteidl/event/event.proto#L269) field and can be used to pass plugin specific context or identifiers. We will use this to pass fast task worker assignment.
N/A
Just merge, not used yet
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [x] To be upstreamed to OSS
ref COR-1581
Closes #393
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
hamersaw
force-pushed
the
union/upstream-33bca79f0
branch
from
5427d3b to
8e6a343
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6115 +/- ##
==========================================
- Coverage 36.98% 36.98% -0.01%
==========================================
Files 1318 1318
Lines 132449 132473 +24
==========================================
+ Hits 48989 48993 +4
- Misses 79207 79226 +19
- Partials 4253 4254 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eapolinario
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Syncs IDL with Union.
What changes were proposed in this pull request?
Adds a custom info field to
ExternalResourceInfo. This is an extension of the ExternalId field and can be used to pass plugin specific context or identifiers. We will use this to pass fast task worker assignment.How was this patch tested?
Tested locally.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
N/A
Docs link
N/A