feat(package_info_plus): Use js_interop instead of html to support compilation to WASM #2625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelbeltran
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening as a replacement for #2622 as there the author couldn't explain clearly why that change was needed in the PR description.
Despite the fact that
package_info_plusalready migrated to packagewebin November in #2316 it was still not fully compatible with WASM according to point 1 here: https://dart.dev/interop/js-interop/package-web#package-web-vs-dart-htmlThere is a suggestion on how imports need to be modified to support WASM compilation: https://dart.dev/interop/js-interop/package-web#conditional-imports
Change in this PR is based on that suggestion.
Related Issues
It was briefly mentioned in #2623 but had poor title and explanation.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).