Skip to content

feat(device_info_plus)!: migrate to package:web #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2024
Merged

feat(device_info_plus)!: migrate to package:web #2624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f854044
migrate device_info_plus to package:web
miquelbeltran Feb 29, 2024
dbe3c04
Navigator requires web 0.5.0
miquelbeltran Feb 29, 2024
157ebb4
external extension function to read device memory
miquelbeltran Feb 29, 2024
ad0ca41
fix type
miquelbeltran Feb 29, 2024
49d98ab
Merge branch 'main' into miquelbeltran/issue2601
miquelbeltran Mar 2, 2024
52582aa
Merge branch 'main' into miquelbeltran/issue2601
miquelbeltran Mar 6, 2024
cb760a1
Merge branch 'main' into miquelbeltran/issue2601
miquelbeltran Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/device_info_plus/device_info_plus/lib/src/device_info_plus_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import 'dart:async';
import 'dart:html' as html show window, Navigator;
import 'package:web/web.dart' as html show window, Navigator;

import 'package:device_info_plus_platform_interface/device_info_plus_platform_interface.dart';
import 'package:flutter_web_plugins/flutter_web_plugins.dart';
Expand Down Expand Up @@ -44,3 +44,10 @@ class DeviceInfoPlusWebPlugin extends DeviceInfoPlatform {
);
}
}

/// Property is missing.
/// Ticket: https://github.com/dart-lang/web/issues/192
/// Probably won't be an int? in the future!
extension on html.Navigator {
external int? get deviceMemory;
}
3 changes: 2 additions & 1 deletion packages/device_info_plus/device_info_plus/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ dependencies:
flutter_web_plugins:
sdk: flutter
meta: ^1.8.0
web: '>=0.5.0 <=0.6.0'

# win32 is compatible across v4 and v5 for Win32 only (not COM)
win32: ">=4.0.0 <6.0.0"
Expand All @@ -46,5 +47,5 @@ dev_dependencies:
test: ^1.22.0

environment:
sdk: ">=2.18.0 <4.0.0"
sdk: ">=3.3.0 <4.0.0"
flutter: ">=3.3.0"