Skip to content

Conversation

tlserver
Copy link
Contributor

Description

As #2248 said:

In previous version, FPPMagnetometerStreamHandlerPlus use deviceMotion instead of magnetometer to allow iOS present calibration interaction. So, in iOS, userAccelerometerEventStream and magnetometerEventStream share the same sampling period. In android, they have their own sampling period.

So this PR use magnetometer instead of deviceMotion. but this is a BREAKING CHANGE!!

Related Issues

Require #2248

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen
Copy link
Collaborator

This PR also need a fix for formatting. Please fix it first.

@tlserver
Copy link
Contributor Author

Formatting issues fixed, please review when you have time~

Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix conflicts?

@tlserver
Copy link
Contributor Author

tlserver commented Nov 23, 2023

Ok, actually only the last commit is needed for this PR, and the previous commits is same as #2248.

Also a small improvement at #2390. Please consider bundle it in one release.

@vbuberen
Copy link
Collaborator

Also a small improvement at #2390. Please consider bundle it in one release.

I won't release plugin update till all your PRs on this topic merged as well as till documentation is updated, so no worries here.

@vbuberen vbuberen merged commit d175102 into fluttercommunity:main Nov 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants