-
Notifications
You must be signed in to change notification settings - Fork 364
feat: Implement isFavorite for Android R+
#1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexV525
merged 4 commits into
fluttercandies:main
from
ColaFanta:feature/add-android-favorite
Nov 15, 2025
Merged
feat: Implement isFavorite for Android R+
#1312
AlexV525
merged 4 commits into
fluttercandies:main
from
ColaFanta:feature/add-android-favorite
Nov 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isFavorite for Android R+
AlexV525
requested changes
Oct 3, 2025
android/src/main/kotlin/com/fluttercandies/photo_manager/core/PhotoManagerFavoriteManager.kt
Outdated
Show resolved
Hide resolved
android/src/main/kotlin/com/fluttercandies/photo_manager/core/PhotoManagerFavoriteManager.kt
Show resolved
Hide resolved
android/src/main/kotlin/com/fluttercandies/photo_manager/core/PhotoManager.kt
Outdated
Show resolved
Hide resolved
android/src/main/kotlin/com/fluttercandies/photo_manager/core/PhotoManagerPlugin.kt
Outdated
Show resolved
Hide resolved
a686006 to
4bd0728
Compare
…_FAVORITE [1] added a `PhotoManagerFavoriteManager` class which implements `is_favorite` for Android R and above where MediaColumns.IS_FAVORITE is introduced [2] updated `Toggle isFavorite` button for `example` project
3f69bfd to
17a79b4
Compare
AlexV525
reviewed
Nov 15, 2025
android/src/main/kotlin/com/fluttercandies/photo_manager/core/PhotoManager.kt
Outdated
Show resolved
Hide resolved
AlexV525
reviewed
Nov 15, 2025
revise doc Co-authored-by: Alex Li <[email protected]>
AlexV525
approved these changes
Nov 15, 2025
Member
AlexV525
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving all suggestions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the AssetEntity.isFavorite property for Android 11 (R) and above.
Changes:
Introduces a
PhotoManagerFavoriteManagerclass to handle the new MediaStore.MediaColumns.IS_FAVORITE column.Populates the
isFavoriteproperty by querying the IS_FAVORITE value from the MediaStore. For Android 10 and below, it is always false as before.Updates the example project with a functional "Toggle isFavorite" button to demonstrate the feature.
CLOSES: #1311