Skip to content

migrate webview_flutter from 3.0 to 4.0 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

migrate webview_flutter from 3.0 to 4.0 #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 40 additions & 58 deletions example/lib/pages/nested/webview.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,7 @@ class NestedWebviewDemo extends StatelessWidget {
child: child,
);
},
child: WebView(
initialUrl: nestedWebviewController.initialUrl,
onPageStarted: nestedWebviewController.onPageStarted,
onPageFinished: nestedWebviewController.onPageFinished,
onWebResourceError:
nestedWebviewController.onWebResourceError,
onWebViewCreated:
nestedWebviewController.onWebViewCreated,
onProgress: nestedWebviewController.onProgress,
javascriptChannels: <JavascriptChannel>{
nestedWebviewController
.scrollHeightNotifierJavascriptChannel
},
javascriptMode: JavascriptMode.unrestricted,
),
child: WebViewWidget(controller:nestedWebviewController._webviewController),
),
if (webViewStatus == WebViewStatus.completed)
SliverToBoxAdapter(
Expand Down Expand Up @@ -189,59 +175,55 @@ class NestedWebviewDemo extends StatelessWidget {
}

class NestedWebviewController {
NestedWebviewController(this.initialUrl);
NestedWebviewController(this.initialUrl){
_webviewController =
WebViewController()
..setJavaScriptMode(JavaScriptMode.unrestricted)
..setNavigationDelegate(
NavigationDelegate(
onProgress: (int progress) {
progressNotifier.value = progress;
},
onPageFinished: (String url) {
if (webViewStatusNotifier.value != WebViewStatus.failed) {
_webviewController?.runJavaScript(scrollHeightJs);
}
webViewStatusNotifier.value = WebViewStatus.completed;
},
onWebResourceError: (WebResourceError error) {
//webViewStatusNotifier.value = WebViewStatus.failed;
},
onPageStarted: (String url) {
if (url == initialUrl ||
webViewStatusNotifier.value == WebViewStatus.failed) {
webViewStatusNotifier.value = WebViewStatus.loading;
}
}
)
)
..addJavaScriptChannel('ScrollHeightNotifier', onMessageReceived: (JavaScriptMessage message) {
final String msg = message.message;
final double? height = double.tryParse(msg);
if (height != null) {
scrollHeightNotifier.value = height;

webViewStatusNotifier.value = WebViewStatus.completed;
}
})
..loadRequest(Uri.parse(initialUrl));
}

final String initialUrl;

WebViewController? _webviewController;
late WebViewController _webviewController;

WebViewController? get webviewController => _webviewController;
WebViewController get webviewController => _webviewController;

ValueNotifier<double> scrollHeightNotifier = ValueNotifier<double>(1);
ValueNotifier<WebViewStatus> webViewStatusNotifier =
ValueNotifier<WebViewStatus>(WebViewStatus.loading);

ValueNotifier<int> progressNotifier = ValueNotifier<int>(0);

void onWebViewCreated(WebViewController controller) {
_webviewController = controller;
}

void onPageStarted(String url) {
if (url == initialUrl ||
webViewStatusNotifier.value == WebViewStatus.failed) {
webViewStatusNotifier.value = WebViewStatus.loading;
}
}

void onPageFinished(String url) {
if (webViewStatusNotifier.value != WebViewStatus.failed) {
//webViewStatusNotifier.value = WebViewStatus.completed;
_webviewController?.runJavascript(scrollHeightJs);
}
}

void onWebResourceError(WebResourceError error) {
webViewStatusNotifier.value = WebViewStatus.failed;
}

void onProgress(int progress) {
progressNotifier.value = progress;
}

JavascriptChannel get scrollHeightNotifierJavascriptChannel =>
JavascriptChannel(
name: 'ScrollHeightNotifier',
onMessageReceived: (JavascriptMessage message) {
final String msg = message.message;
final double? height = double.tryParse(msg);
if (height != null) {
scrollHeightNotifier.value = height;

webViewStatusNotifier.value = WebViewStatus.completed;
}
},
);
}

enum WebViewStatus {
Expand Down