-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[Android] Add breaking changes page on default ABI filters #12350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Visit the preview URL for this PR (updated for commit e82fe86): https://flutter-docs-prod--pr12350-abi-filters-w5bhno49.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is in draft, but I reviewed it anyway. ;). I have a few tweaks over the word "may" but otherwise it looks great!
src/content/release/breaking-changes/default-abi-filters-android.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/default-abi-filters-android.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/default-abi-filters-android.md
Outdated
Show resolved
Hide resolved
…id.md Co-authored-by: Shams Zakhour <[email protected]>
…id.md Co-authored-by: Shams Zakhour <[email protected]>
…id.md Co-authored-by: Shams Zakhour <[email protected]>
|
@gmackall Can you take a look to make sure this is right? Made this change instead of attempting to put it in the blog because this feels moreso like the right place, but let me know if you disagree. Thanks! |
| - `arm64-v8a` | ||
| - `x86_64` | ||
|
|
||
| Because this automatic configuration happens after your `build.gradle` files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not exactly correct - the configuration happens before. It just breaks those who were depending on the set to be empty.
Previously, it would be. Now we add elements to it during configuration that happens before the user's build.gradle file. This is why clearing still works (otherwise it wouldn't matter what they wrote in their build.gradle at all).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh I see I see. Corrected "after" to "before"!
I think this is the right place as well, mostly looks good but one comment on the ordering of gradle configuration. |
src/content/release/breaking-changes/default-abi-filters-android.md
Outdated
Show resolved
Hide resolved
|
Why does the flutter/flutter#174004 issue still exist on version Flutter is already up to date on channel [user-branch]
Flutter 3.35.2 • channel [user-branch] • https://github.com/flutter/flutter.git
Framework • revision 05db968908 (9 小时前) • 2025-08-25 10:21:35 -0700
Engine • hash abb725c9a5211af2a862b83f74b7eaf2652db083 (revision a8bfdfc394) (3 days ago) • 2025-08-22 23:51:12.000Z
Tools • Dart 3.9.0 • DevTools 2.48.0 |
…id.md Co-authored-by: Gray Mackall <[email protected]>
@angcyo are you saying that the fix detailed here does not work for you on the latest stable? |
| Because this automatic configuration happens before your `build.gradle` files | ||
| are processed, it might override custom `abiFilters` settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would just say something more explicitly like this:
| Because this automatic configuration happens before your `build.gradle` files | |
| are processed, it might override custom `abiFilters` settings. | |
| Because this automatic configuration happens before your `build.gradle` files | |
| are processed, it might break custom `abiFilters` settings that depend on the set being empty. |
I think the current structure could be confusing, as one would wonder something that happens before would override settings.
gmackall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a nit for how I would prefer it but LGTM either way now
Yes, I updated to 3.35.2, but it still didn't work. I use Here is a minimum verification problem project : https://github.com/angcyo/flutter_abi_filters_demo
Is it a problem with the Is there no problem if I tried
Should I reconsider merging my PR : flutter/flutter#174008 |
|
@angcyo Have you tried using |
I've tried everything, but the problem still exists. |
|
@gmackall Do you know why this solution may not work in some cases? I took a look at the build.gradle files in https://github.com/angcyo/flutter_abi_filters_demo and nothing jumps out to me. |
is there any progress? |
|
What's the situation now? |
@angcyo The migration guide is saying to set ABI filters in |
|
By the way, this migration guide here doesn't link to any pages.
|
|
@RaadShariat thank you so much for pointing this out! Putting up a fix now: #12379 |


Description of what this PR is changing or adding, and why:
Adds a breaking change for flutter/flutter#168293 which landed in 3.35. TLDR: To set custom Android ABI filters, you must clear the defaults that Flutter sets or use the Flutter-provided flag for doing so.
Issues fixed by this PR (if any):
Fixes flutter/flutter#174004
PRs or commits this PR depends on (if any):
N/A
Presubmit checklist
of 80 characters or fewer.