fix: compass-app bug in dismissable homescreen item #2449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some testing on the "Optimistic State" I noticed the use of
Dismissablewas incorrect.If the delete request failed and the item cannot be removed, the removed item then gets stays in the item list.
This causes the
Dismissablewidget to throw an exception, because it expects that the item with a unique key has been removed. To fix that, I switched fromonDismissedtoconfirmDismiss, and use theCommandstatus result to know if the dismiss action was successful or not.I have created a widget test that reproduces the issue.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.