Skip to content

Conversation

@davidmartos96
Copy link
Contributor

Support emojis in templates. The code was relying on String.length, when doing substring, which could be wrong when emojis are used.

Fixes flutter/flutter#176180

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds emoji support to the mustache template parser by correctly handling runes instead of UTF-16 code units. The changes in scanner.dart correctly use runes for parsing, and new tests have been added to verify emoji handling.

I've identified a performance issue with the current approach in scanner.dart and suggested a more memory-efficient implementation. Additionally, I found a small error in one of the new tests regarding character offsets.

As a side note for future improvements, while parsing is fixed, the error reporting in TemplateException might still have issues with emojis, as it appears to use code unit-based offsets. This could be a good follow-up to ensure full emoji support across the package.

@davidmartos96 davidmartos96 changed the title Emoji support [mustache_template] Emoji support Sep 29, 2025
@stuartmorgan-g
Copy link
Collaborator

From triage: Ping @bkonyi / @parlough on this review

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this and adding the additional tests!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 22, 2025

autosubmit label was removed for flutter/packages/10110, because - The status or check suite Linux_android android_device_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2025
@auto-submit auto-submit bot merged commit ce0b99c into flutter:main Oct 22, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Oct 23, 2025
flutter/packages@d113bbc...9ec29b6

2025-10-22 [email protected] [go_router] Support for top level
`onEnter` callback. (flutter/packages#8339)
2025-10-22 [email protected] [go_router_builder] Ignore experimental
features (flutter/packages#10275)
2025-10-22 [email protected] Roll Flutter from
2d34167 to 75004a6 (39 revisions) (flutter/packages#10279)
2025-10-22 [email protected] [ci]Adds mechanism
for packages to opt in to batched release (flutter/packages#10237)
2025-10-22 [email protected] [tool] Change
gradle-check logic to enforce alignment of java versions and a minimum
(17) (flutter/packages#10206)
2025-10-22 [email protected] [various] Migrate example Radio groups
to new RadioGroup API (flutter/packages#10155)
2025-10-22 [email protected] [mustache_template] Emoji support
(flutter/packages#10110)
2025-10-22 [email protected] [image_picker] Fix
typos in error messages for android (flutter/packages#10188)
2025-10-22 [email protected] [image_picker] Fix
typos in error messages for platform interface (flutter/packages#10211)
2025-10-21 [email protected] [camera_avfoundation] Wrappers
swift migration - part 1 (flutter/packages#10119)
2025-10-21 [email protected] [go_router_builder] expand supported
versions of analyzer, build and source_gen (flutter/packages#10078)
2025-10-20 [email protected] Roll Flutter from
891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Oct 24, 2025
flutter/packages@d113bbc...9ec29b6

2025-10-22 [email protected] [go_router] Support for top level
`onEnter` callback. (flutter/packages#8339)
2025-10-22 [email protected] [go_router_builder] Ignore experimental
features (flutter/packages#10275)
2025-10-22 [email protected] Roll Flutter from
2d34167 to 75004a6 (39 revisions) (flutter/packages#10279)
2025-10-22 [email protected] [ci]Adds mechanism
for packages to opt in to batched release (flutter/packages#10237)
2025-10-22 [email protected] [tool] Change
gradle-check logic to enforce alignment of java versions and a minimum
(17) (flutter/packages#10206)
2025-10-22 [email protected] [various] Migrate example Radio groups
to new RadioGroup API (flutter/packages#10155)
2025-10-22 [email protected] [mustache_template] Emoji support
(flutter/packages#10110)
2025-10-22 [email protected] [image_picker] Fix
typos in error messages for android (flutter/packages#10188)
2025-10-22 [email protected] [image_picker] Fix
typos in error messages for platform interface (flutter/packages#10211)
2025-10-21 [email protected] [camera_avfoundation] Wrappers
swift migration - part 1 (flutter/packages#10119)
2025-10-21 [email protected] [go_router_builder] expand supported
versions of analyzer, build and source_gen (flutter/packages#10078)
2025-10-20 [email protected] Roll Flutter from
891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@davidmartos96 davidmartos96 deleted the emoji branch October 27, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mustache_template] Emoji support

4 participants