-
Couldn't load subscription status.
- Fork 3.5k
[mustache_template] Emoji support #10110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds emoji support to the mustache template parser by correctly handling runes instead of UTF-16 code units. The changes in scanner.dart correctly use runes for parsing, and new tests have been added to verify emoji handling.
I've identified a performance issue with the current approach in scanner.dart and suggested a more memory-efficient implementation. Additionally, I found a small error in one of the new tests regarding character offsets.
As a side note for future improvements, while parsing is fixed, the error reporting in TemplateException might still have issues with emojis, as it appears to use code unit-based offsets. This could be a good follow-up to ensure full emoji support across the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this and adding the additional tests!
|
autosubmit label was removed for flutter/packages/10110, because - The status or check suite Linux_android android_device_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@d113bbc...9ec29b6 2025-10-22 [email protected] [go_router] Support for top level `onEnter` callback. (flutter/packages#8339) 2025-10-22 [email protected] [go_router_builder] Ignore experimental features (flutter/packages#10275) 2025-10-22 [email protected] Roll Flutter from 2d34167 to 75004a6 (39 revisions) (flutter/packages#10279) 2025-10-22 [email protected] [ci]Adds mechanism for packages to opt in to batched release (flutter/packages#10237) 2025-10-22 [email protected] [tool] Change gradle-check logic to enforce alignment of java versions and a minimum (17) (flutter/packages#10206) 2025-10-22 [email protected] [various] Migrate example Radio groups to new RadioGroup API (flutter/packages#10155) 2025-10-22 [email protected] [mustache_template] Emoji support (flutter/packages#10110) 2025-10-22 [email protected] [image_picker] Fix typos in error messages for android (flutter/packages#10188) 2025-10-22 [email protected] [image_picker] Fix typos in error messages for platform interface (flutter/packages#10211) 2025-10-21 [email protected] [camera_avfoundation] Wrappers swift migration - part 1 (flutter/packages#10119) 2025-10-21 [email protected] [go_router_builder] expand supported versions of analyzer, build and source_gen (flutter/packages#10078) 2025-10-20 [email protected] Roll Flutter from 891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@d113bbc...9ec29b6 2025-10-22 [email protected] [go_router] Support for top level `onEnter` callback. (flutter/packages#8339) 2025-10-22 [email protected] [go_router_builder] Ignore experimental features (flutter/packages#10275) 2025-10-22 [email protected] Roll Flutter from 2d34167 to 75004a6 (39 revisions) (flutter/packages#10279) 2025-10-22 [email protected] [ci]Adds mechanism for packages to opt in to batched release (flutter/packages#10237) 2025-10-22 [email protected] [tool] Change gradle-check logic to enforce alignment of java versions and a minimum (17) (flutter/packages#10206) 2025-10-22 [email protected] [various] Migrate example Radio groups to new RadioGroup API (flutter/packages#10155) 2025-10-22 [email protected] [mustache_template] Emoji support (flutter/packages#10110) 2025-10-22 [email protected] [image_picker] Fix typos in error messages for android (flutter/packages#10188) 2025-10-22 [email protected] [image_picker] Fix typos in error messages for platform interface (flutter/packages#10211) 2025-10-21 [email protected] [camera_avfoundation] Wrappers swift migration - part 1 (flutter/packages#10119) 2025-10-21 [email protected] [go_router_builder] expand supported versions of analyzer, build and source_gen (flutter/packages#10078) 2025-10-20 [email protected] Roll Flutter from 891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Support emojis in templates. The code was relying on String.length, when doing substring, which could be wrong when emojis are used.
Fixes flutter/flutter#176180
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3