Make sure that a BottomSheet doesn't crash in 0x0 environment #172229

ahmedsameha1 · 2025-07-16T13:24:16Z

This is my attempt to handle #6537 for the BottomSheet UI control.

dkwingsmt

LGTM

ahmedsameha1 · 2025-07-24T19:50:21Z

Thank you for reviewing.

MitchellGoodwin · 2025-07-24T20:42:27Z

packages/flutter/test/material/bottom_sheet_test.dart

+      ),
+    );
+    final Finder xText = find.text('X');
+    expect(tester.getSize(xText), Size.zero);


Should this go back to .isEmpty like the other PRs for consistency? @dkwingsmt

Yeah you're right.

dkwingsmt

Checklist:

The test is in the correct file
The test name goes “does not crash at zero area”
The target widget is wrapped by Center (or is fullscreen)
The target widget does not have an overlay, or the overlay is tested
The target widget is expected to have a size of exactly Size.zero

dkwingsmt · 2025-09-18T05:04:27Z

packages/flutter/test/material/bottom_sheet_test.dart

    expect(focusNode.hasFocus, true);
  });
+
+  testWidgets('BottomSheet renders at zero area', (WidgetTester tester) async {


Suggested change

testWidgets('BottomSheet renders at zero area', (WidgetTester tester) async {

testWidgets('BottomSheet does not crash at zero area', (WidgetTester tester) async {

dkwingsmt · 2025-09-18T05:05:11Z

packages/flutter/test/material/bottom_sheet_test.dart

+    final Finder xText = find.text('X');
+    expect(tester.getSize(xText).isEmpty, isTrue);


Suggested change

final Finder xText = find.text('X');

expect(tester.getSize(xText).isEmpty, isTrue);

expect(tester.getSize(find.byType(BottomSheet)), Size.zero);

dkwingsmt · 2025-09-18T05:05:26Z

packages/flutter/test/material/bottom_sheet_test.dart

+    await tester.pumpWidget(
+      MaterialApp(
+        home: Scaffold(
+          body: SizedBox.shrink(


Wrap it with Center.

dkwingsmt

LGTM

auto-submit · 2025-10-20T20:24:38Z

autosubmit label was removed for flutter/flutter/172229, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

…nt (flutter/flutter#172229)

Roll Flutter from 2d3416713fe8 to 75004a639ae4 (39 revisions) flutter/flutter@2d34167...75004a6 2025-10-22 [email protected] [Impeller] Add the paint color to the key of the text shadow cache (flutter/flutter#177140) 2025-10-22 [email protected] Roll Skia from 96e75ca8e24b to 928b5cf727c1 (2 revisions) (flutter/flutter#177387) 2025-10-22 [email protected] Roll reclient to version 185 (flutter/flutter#177293) 2025-10-22 [email protected] Roll Skia from b157f6b95f95 to 96e75ca8e24b (4 revisions) (flutter/flutter#177366) 2025-10-22 [email protected] Fix InputDatePickerFormField does not inherit local InputDecorationTheme (flutter/flutter#177090) 2025-10-22 [email protected] Roll Skia from 2c6162c977db to b157f6b95f95 (2 revisions) (flutter/flutter#177362) 2025-10-22 [email protected] Roll Skia from cadf8e7e6fca to 2c6162c977db (4 revisions) (flutter/flutter#177359) 2025-10-22 [email protected] Cleanup after -news_toolkit, +google_fonts, and some leftover `team-go_router` (flutter/flutter#176841) 2025-10-21 [email protected] don't break sheet's snap from physics (flutter/flutter#171157) 2025-10-21 [email protected] Roll Dart SDK from 913c2ae1b367 to c23010c4f9e6 (8 revisions) (flutter/flutter#177348) 2025-10-21 [email protected] Fix typo in comment about screen availibility (flutter/flutter#177168) 2025-10-21 [email protected] Fix(AnimatedScrollView): exclude outgoing items in removeAllItems (flutter/flutter#176452) 2025-10-21 [email protected] Enable deprecated_member_use_from_same_package for all packages containing tests of Dart fixes defined within the package (flutter/flutter#177341) 2025-10-21 [email protected] Roll Skia from 19bff385f7e8 to cadf8e7e6fca (3 revisions) (flutter/flutter#177331) 2025-10-21 [email protected] Revert "[Android 16] Update `android_engine_vulkan_tests` to Test Against SDK 36 Emulator" (flutter/flutter#177292) 2025-10-21 [email protected] Fix SliverMainAxisGroup.cacheOrigin (flutter/flutter#175760) 2025-10-21 [email protected] Roll Skia from 75c756e029c9 to 19bff385f7e8 (3 revisions) (flutter/flutter#177316) 2025-10-21 [email protected] Fix typo in overlay.dart documentation comment (flutter/flutter#176612) 2025-10-21 [email protected] [ Tool ] Output DTD URI for Flutter web applications (flutter/flutter#177310) 2025-10-21 [email protected] Roll Skia from 982988b472a4 to 75c756e029c9 (1 revision) (flutter/flutter#177305) 2025-10-21 [email protected] Roll Skia from 42ff13a91c80 to 982988b472a4 (8 revisions) (flutter/flutter#177300) 2025-10-21 [email protected] Fix DateRangePickerDialog does not inherit local InputDecorationTheme (flutter/flutter#177086) 2025-10-21 [email protected] Remove references to dart:_js_annotations (flutter/flutter#176698) 2025-10-20 [email protected] Make `FlutterSceneLifeCycleProvider.sceneLifeCycleDelegate` readonly (flutter/flutter#177240) 2025-10-20 [email protected] Make sure that a CupertinoDesktopTextSelectionToolbar doesn't crash i… (flutter/flutter#173964) 2025-10-20 [email protected] Make sure that a BottomSheet doesn't crash in 0x0 environment (flutter/flutter#172229) 2025-10-20 [email protected] Move the Fuchsia SDK to //third_party/fuchsia-sdk (flutter/flutter#177118) 2025-10-20 [email protected] Roll Skia from 641994569415 to 42ff13a91c80 (8 revisions) (flutter/flutter#177283) 2025-10-20 [email protected] Make sure that a NavigationDrawer doesn't crash in 0x0 environment (flutter/flutter#176951) 2025-10-20 [email protected] Fix ink features painting in TabBar. (flutter/flutter#177155) 2025-10-20 [email protected] Make sure that SimpleDialog and SimpleDialogOption do not crash in 0x0 environment (flutter/flutter#174229) 2025-10-20 [email protected] Fix ink features painting in YearPicker. (flutter/flutter#177014) 2025-10-20 [email protected] Update `image.error_builder.0.dart` to replace the emoji with some text (flutter/flutter#176886) 2025-10-20 [email protected] Roll Skia from ed4294faecde to 641994569415 (4 revisions) (flutter/flutter#177264) 2025-10-20 [email protected] Remove redundant name field form `TargetPlatform` and `XCDeviceEventInterface` enums (flutter/flutter#176890) 2025-10-20 [email protected] Added support to pass in texture type while creating textures. (flutter/flutter#175376) 2025-10-20 [email protected] Roll Packages from 3747006 to d113bbc (6 revisions) (flutter/flutter#177270) 2025-10-20 [email protected] Roll Dart SDK from 2cd2106f2cef to 913c2ae1b367 (2 revisions) (flutter/flutter#177258) 2025-10-20 [email protected] Added link to ClipRect from ImageFilter in the docstring (flutter/flutter#177196) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 16, 2025

dkwingsmt self-requested a review July 16, 2025 18:17

dkwingsmt approved these changes Jul 24, 2025

View reviewed changes

MitchellGoodwin reviewed Jul 24, 2025

View reviewed changes

dkwingsmt self-requested a review August 27, 2025 18:22

dkwingsmt reviewed Sep 18, 2025

View reviewed changes

ahmedsameha1 force-pushed the handle#6537-BottomSheet branch from 10bdfc1 to f8cfaf2 Compare September 22, 2025 09:07

dkwingsmt approved these changes Sep 23, 2025

View reviewed changes

ahmedsameha1 and others added 4 commits October 8, 2025 16:23

Make sure that a BottomSheet doesn't crash in 0x0 environment

6bef040

Use Size.zero instead of Size.isEmpty() in the zero area test

8238600

isEmpty

4e28e52

Using Size.zero instead of isEmpty

26d6026

dkwingsmt force-pushed the handle#6537-BottomSheet branch from 57c7555 to 26d6026 Compare October 8, 2025 23:23

dkwingsmt requested a review from MitchellGoodwin October 8, 2025 23:23

dkwingsmt requested a review from victorsanni October 16, 2025 21:49

victorsanni approved these changes Oct 17, 2025

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2025

Merge branch 'master' into handle#6537-BottomSheet

82e6fe8

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2025

auto-submit bot added this pull request to the merge queue Oct 20, 2025

Merged via the queue into flutter:master with commit 246a6a2 Oct 21, 2025
77 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 21, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 21, 2025

246a6a2f2 Make sure that a BottomSheet doesn't crash in 0x0 environme…

2092ec3

…nt (flutter/flutter#172229)

This was referenced Oct 21, 2025

Roll Flutter from 2d3416713fe8 to d20b961f00c7 (20 revisions) flutter/packages#10269

Closed

Roll Flutter from 2d3416713fe8 to 773acaf2ab4d (21 revisions) flutter/packages#10270

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 21, 2025

246a6a2f2 Make sure that a BottomSheet doesn't crash in 0x0 environme…

5b158bd

…nt (flutter/flutter#172229)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 21, 2025

246a6a2f2 Make sure that a BottomSheet doesn't crash in 0x0 environme…

8ff11d7

…nt (flutter/flutter#172229)

engine-flutter-autoroll mentioned this pull request Oct 21, 2025

Roll Flutter from 2d3416713fe8 to 97d0dd634e3e (22 revisions) flutter/packages#10271

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 21, 2025

246a6a2f2 Make sure that a BottomSheet doesn't crash in 0x0 environme…

f4f69a1

…nt (flutter/flutter#172229)

This was referenced Oct 21, 2025

Roll Flutter from 2d3416713fe8 to 27d070b22463 (25 revisions) flutter/packages#10272

Closed

Roll Flutter from 2d3416713fe8 to 280f34408f8d (37 revisions) flutter/packages#10277

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 22, 2025

246a6a2f2 Make sure that a BottomSheet doesn't crash in 0x0 environme…

f15f861

…nt (flutter/flutter#172229)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 22, 2025

246a6a2f2 Make sure that a BottomSheet doesn't crash in 0x0 environme…

6a81515

…nt (flutter/flutter#172229)

engine-flutter-autoroll mentioned this pull request Oct 22, 2025

Roll Flutter from 2d3416713fe8 to daa311368ec4 (38 revisions) flutter/packages#10278

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 22, 2025

246a6a2f2 Make sure that a BottomSheet doesn't crash in 0x0 environme…

3673ba0

…nt (flutter/flutter#172229)

engine-flutter-autoroll mentioned this pull request Oct 22, 2025

Roll Flutter from 2d3416713fe8 to 75004a639ae4 (39 revisions) flutter/packages#10279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make sure that a BottomSheet doesn't crash in 0x0 environment #172229

Make sure that a BottomSheet doesn't crash in 0x0 environment #172229

ahmedsameha1 commented Jul 16, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

ahmedsameha1 commented Jul 24, 2025

Uh oh!

MitchellGoodwin Jul 24, 2025

Uh oh!

dkwingsmt Jul 30, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

dkwingsmt Sep 18, 2025

Uh oh!

dkwingsmt Sep 18, 2025

Uh oh!

dkwingsmt Sep 18, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

auto-submit bot commented Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	testWidgets('BottomSheet renders at zero area', (WidgetTester tester) async {
	testWidgets('BottomSheet does not crash at zero area', (WidgetTester tester) async {

		final Finder xText = find.text('X');
		expect(tester.getSize(xText).isEmpty, isTrue);

	final Finder xText = find.text('X');
	expect(tester.getSize(xText).isEmpty, isTrue);
	expect(tester.getSize(find.byType(BottomSheet)), Size.zero);

Make sure that a BottomSheet doesn't crash in 0x0 environment #172229

Make sure that a BottomSheet doesn't crash in 0x0 environment #172229

Conversation

ahmedsameha1 commented Jul 16, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedsameha1 commented Jul 24, 2025

Uh oh!

MitchellGoodwin Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants