Fix bug with debugging support code not getting injected on edge devices

[jyameo]

This PR addresses flutter/flutter#167102, where debugging support code was not being properly injected when running on Edge flutter run -d edge. The issue was due to missing conditions in the injection logic that prevented the debugger service from initializing correctly in this environment.

This change ensures that debugging support is consistently injected when connected devices are present and the user has selected one of them.

fix #167102.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[bkonyi]

The fix LGTM, but is it possible to write a test for this?

[jyameo]

The fix LGTM, but is it possible to write a test for this?

Thanks, Ben! I'll see what I can do in terms of testing.

@srujzs, do we have any existing tests that verify the app runs as expected across various devices (chrome, edge, web-server, etc..)? If so, could you please point me to the relevant code or files where I can find them?

[srujzs]

I'm not sure if we have good coverage here, but I'm not that familiar with the testing here. There's devices_test.dart but that appears to be more of a capabilities test than an integration test. One option might be to fork web_run_test.dart to run with Edge and --web-server and make sure there are no errors/the run succeeds.

[jyameo]

I'm not sure if we have good coverage here, but I'm not that familiar with the testing here. There's devices_test.dart but that appears to be more of a capabilities test than an integration test. One option might be to fork web_run_test.dart to run with Edge and --web-server and make sure there are no errors/the run succeeds.

Hi @srujzs, I'm working on implementing the test for running Flutter on Microsoft Edge devices based on web_run_test.dart. However, Siva brought to my attention that the bots might not be set up with Edge capabilities. I wanted to check with you to confirm. Will we actually be able to run this test on Microsoft Edge in our CI bots once it's implemented? Also is there a way I can check what devices are supported by the bots?

[srujzs]

However, Siva brought to my attention that the bots might not be set up with Edge capabilities. I wanted to check with you to confirm. Will we actually be able to run this test on Microsoft Edge in our CI bots once it's implemented? Also is there a way I can check what devices are supported by the bots?

You've reached the edge of my knowledge. :) I don't know how they're configured, but I'd reach out to the Flutter infra folks to see if they know more. I don't recall coming across any Edge tests, so it's certainly possible that we aren't testing it.

[jyameo]

However, Siva brought to my attention that the bots might not be set up with Edge capabilities. I wanted to check with you to confirm. Will we actually be able to run this test on Microsoft Edge in our CI bots once it's implemented? Also is there a way I can check what devices are supported by the bots?

You've reached the edge of my knowledge. :) I don't know how they're configured, but I'd reach out to the Flutter infra folks to see if they know more. I don't recall coming across any Edge tests, so it's certainly possible that we aren't testing it.

Got it, thanks Srujan! I'll follow up with the Flutter infra team to confirm whether Edge is supported in the test environment. And nice pun, seems like we’ve literally reached the Edge here. 😄

[jyameo]

However, Siva brought to my attention that the bots might not be set up with Edge capabilities. I wanted to check with you to confirm. Will we actually be able to run this test on Microsoft Edge in our CI bots once it's implemented? Also is there a way I can check what devices are supported by the bots?

You've reached the edge of my knowledge. :) I don't know how they're configured, but I'd reach out to the Flutter infra folks to see if they know more. I don't recall coming across any Edge tests, so it's certainly possible that we aren't testing it.

Got it, thanks Srujan! I'll follow up with the Flutter infra team to confirm whether Edge is supported in the test environment. And nice pun, seems like we’ve literally reached the Edge here. 😄

Hi @srujzs and @bkonyi, I reached out to the Flutter infra team to ask about Edge support, and it turns out we currently don't have bots set up with Edge-specific testing capabilities. So unfortunately, we won't be able to implement a test that runs specifically on Microsoft Edge in CI at this time.

[bkonyi]

We'll consider this test exempt since we don't have the infra to test this.

LGTM!