Skip to content

Conversation

jwren
Copy link
Member

@jwren jwren commented Aug 27, 2025

This file contains local code style settings and should not be tracked in the repository. It has been added to .gitignore to prevent future commits.

This file contains local code style settings and should not be tracked in the repository. It has been added to .gitignore to prevent future commits.
@pq
Copy link
Collaborator

pq commented Aug 27, 2025

I was expecting a .gitignore update here?

@pq
Copy link
Collaborator

pq commented Aug 27, 2025

If we aren't tracking code style, should we have instructions for setting up team settings in the CONTRIBUTING docs?

@jwren
Copy link
Member Author

jwren commented Aug 27, 2025

I was expecting a .gitignore update here?

It was still cached by git before the .gitignore change in this commit: 8435754

@jwren
Copy link
Member Author

jwren commented Aug 27, 2025

If we aren't tracking code style, should we have instructions for setting up team settings in the CONTRIBUTING docs?

Yes, I am happy to modify it, were there other recommendations other than the wild cards, I cannot remember.

@pq
Copy link
Collaborator

pq commented Aug 27, 2025

Ah... I'm still confused by the PR title.

[cq] Untrack .idea/codeStyles/Project.xml #8493

This doesn't seem to be doing that?

@pq
Copy link
Collaborator

pq commented Aug 27, 2025

If we aren't tracking code style, should we have instructions for setting up team settings in the CONTRIBUTING docs?

Yes, I am happy to modify it, were there other recommendations other than the wild cards, I cannot remember.

Great question. That's the one that jumps out at me. @helin24 may recall more.

Here's a good place for a continued conversation: #8098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants