Skip to content

Conversation

@ArturAssisComp
Copy link
Member

Connection with issue(s)

No. The change is so simple that I decided not to create a related issue.

Solution description

Added a new item for the breaking change log for the match validator. This validator had the type of its positional parameter changed from String (with name pattern) to RegEx (with name regex).

Screenshots or Videos

Before:

static FormFieldValidator<String> match(
    String pattern, {
    String? errorText,
  }) =>...

After:
image

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (93d6fb2) to head (cf2e899).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files          92       92           
  Lines        1002     1002           
=======================================
  Hits          952      952           
  Misses         50       50           
Flag Coverage Δ
unittests 95.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deandreamatias
Copy link
Contributor

Nice! Thanks for contribution

@deandreamatias deandreamatias merged commit da39169 into flutter-form-builder-ecosystem:main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants