Skip to content

Conversation

@martijn00
Copy link
Contributor

@martijn00 martijn00 commented May 24, 2024

Connection with issue(s)

Close #100
Close #58
Close #71

Connected to #???

Solution description

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@martijn00
Copy link
Contributor Author

@deandreamatias can you review this one? I'll add the translations for all other languages if everything is alright

Copy link
Contributor

@deandreamatias deandreamatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of new validators, this is impressive!
But you can also add a dynamic value generator for the test, to increase the randomness and reliability of tests.

Can use the faker_dart package like dev_dependency and use on tests

@martijn00 martijn00 requested a review from deandreamatias May 26, 2024 12:27
@deandreamatias deandreamatias merged commit 79bf0ca into flutter-form-builder-ecosystem:main May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TextField]: Password validations

3 participants