Skip to content

Fix null-reference exception #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2018
Merged

Fix null-reference exception #48

merged 1 commit into from
Jun 20, 2018

Conversation

@ErikSchierboom
Copy link
Contributor

@ErikSchierboom ErikSchierboom commented Jun 19, 2018 •
edited by Meir017
Loading

closes #49
When running the analyzers on my project using VS 2017 (version 15.7.4), I encountered two null-reference exceptions. This PR fixes those.

@Meir017
Copy link
Member

Meir017 commented Jun 19, 2018

Thanks for opening this issue (and the fix)

Could you add a test for this case in the SanityTests class?

@Meir017 Meir017 added the bug label Jun 19, 2018
@ErikSchierboom
Copy link
Contributor Author

ErikSchierboom commented Jun 19, 2018

@Meir017 I'll try!

@ErikSchierboom ErikSchierboom mentioned this pull request Jun 20, 2018
Closed
@ErikSchierboom ErikSchierboom force-pushed the fix-null-reference-exceptions branch from 45ce650 to e619804 Compare June 20, 2018 06:16
@ErikSchierboom ErikSchierboom changed the title Fix null-reference exceptions WIP Fix null-reference exceptions Jun 20, 2018
Meir017
Meir017 approved these changes Jun 20, 2018
View reviewed changes
Copy link
Member

@Meir017 Meir017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) I'll merge this later today and release 0.10.3

@ErikSchierboom
Copy link
Contributor Author

ErikSchierboom commented Jun 20, 2018

@Meir017 There might be another null-reference exception, but I have yet to create a repro.

@ErikSchierboom ErikSchierboom changed the title WIP Fix null-reference exceptions Fix null-reference exception Jun 20, 2018
@Meir017 Meir017 removed the bug label Jun 20, 2018
@Meir017 Meir017 merged commit 44e2860 into fluentassertions:master Jun 20, 2018
@ErikSchierboom ErikSchierboom deleted the fix-null-reference-exceptions branch June 20, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Meir017 Meir017 Meir017 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Writing to System.Console should not throw an exception

2 participants

@ErikSchierboom @Meir017