Skip to content

wrap logic in try-catch and log errors #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2021
Merged

wrap logic in try-catch and log errors #106

merged 2 commits into from
Oct 7, 2021

Conversation

@Meir017
Copy link
Member

@Meir017 Meir017 commented Oct 6, 2021

closes #100

@Meir017
Copy link
Member Author

Meir017 commented Oct 6, 2021

@JamesDriscoll take a look a this

JamesDriscoll
JamesDriscoll approved these changes Oct 7, 2021
View reviewed changes
Copy link

@JamesDriscoll JamesDriscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have gone for "Safe" as a prefix on one method, and as a suffix on the other.
Do you want to be consistent?
And does "Safely" as a suffix improve clarity?

@Meir017
Copy link
Member Author

Meir017 commented Oct 7, 2021

@JamesDriscoll good idea!

@Meir017 Meir017 merged commit e16dfce into master Oct 7, 2021
@Meir017 Meir017 deleted the 100-catch-uncought-exception branch October 7, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JamesDriscoll JamesDriscoll JamesDriscoll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Catch currently uncought exceptions

3 participants

@Meir017 @JamesDriscoll